bulbazord added inline comments.
================ Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFAbbreviationDeclaration.h:61 uint8_t m_has_children = 0; - DWARFAttribute::collection m_attributes; }; ---------------- kastiglione wrote: > With this change, can the following be removed from` DWARFAttribute.h`? > > ``` > typedef std::vector<DWARFAttribute> collection; > typedef collection::iterator iterator; > typedef collection::const_iterator const_iterator; > ``` > Possibly? I sort of put this patch on the back burner... but it would be nice to get rid of those as well! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149214/new/ https://reviews.llvm.org/D149214 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
