tahonermann requested changes to this revision. tahonermann added a comment. This revision now requires changes to proceed.
> I do wonder if we need two bfloat implementations, but for that I'll leave a > comment on D149573 <https://reviews.llvm.org/D149573>. Given the discussions occurring in D149573 <https://reviews.llvm.org/D149573>, let's hold off on landing this for now. It is sounding like we might have direction for repurposing `__bf16` for `std::bfloat16_t` (and a future `_BFloat16` C type; with `__bf16` retained as an alternate spelling). If we go in that direction, then we would presumably want a change that goes in the opposite direction of this patch; a change that migrates "bf16" names towards "bfloat16". Let's focus on confirming that direction first. I'll mark this as requesting changes for now while we figure this out. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150291/new/ https://reviews.llvm.org/D150291 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
