Michael137 added a comment.

In D149949#4341608 <https://reviews.llvm.org/D149949#4341608>, @labath wrote:

> Just as a drive-by, since we're constructing a copy anyway it would be 
> possible to merge this construction with the "uniqueing" behavior of the 
> `visited` set. I.e., instead of making a literal copy of the map, just 
> construct a `to_be_visited` set of /unique/ objects, and then iterate over 
> that.

Agreed that would be a nice cleanup. I considered it initially but thought I'd 
split it out into a separate patch (but never did)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149949/new/

https://reviews.llvm.org/D149949

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to