kastiglione added inline comments.
================ Comment at: lldb/examples/python/crashlog.py:703 + symbol = ( + r'(?: +(?:' # spaces and + sign + r'(.+)' # symbol name ---------------- this is just "spaces", not "spaces and + sign" ================ Comment at: lldb/examples/python/crashlog.py:705 + r'(.+)' # symbol name + r'(?: \+ ' # spaces and + sign + r'(\d+)' # symbol offset ---------------- this is "space and + sign" not "spaces" ================ Comment at: lldb/examples/python/crashlog.py:710 + r'([^\:]+)' # file name + r'\:(\d+)' # line number + r'(?:\:' # capture group garbage ---------------- `:` does not need to be escaped CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146765/new/ https://reviews.llvm.org/D146765 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
