mysterymath added a comment. In D151269#4366484 <https://reviews.llvm.org/D151269#4366484>, @JDevlieghere wrote:
> The change itself looks fine, but isn't this an issue for the API tests too? > If so, how is the sys root passed to `dotest.py` and can the shell tests do > the same? Ah, thanks for the heads up. I couldn't find anything in the API tests that pass through a sysroot, so this may also be something to deal with there as well. It's not very straightforward to reproduce this on our end though; the sysrooted builders we're working with don't yet have a suitable Python for LLDB, but we'll likely run into this the moment we try include one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151269/new/ https://reviews.llvm.org/D151269 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits