JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at:
lldb/source/Plugins/StructuredData/DarwinLog/StructuredDataDarwinLog.cpp:1496-1500
LLDB_LOGF(log,
"StructuredDataDarwinLog::%s() warning: no plugin for "
"feature %s in process uid %u",
- __FUNCTION__, GetDarwinLogTypeName().AsCString(),
+ __FUNCTION__, GetDarwinLogTypeName().str().c_str(),
process_sp->GetUniqueID());
----------------
You could get rid of the `.str().c_str()` if you used `LLDB_LOG`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151599/new/
https://reviews.llvm.org/D151599
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
