kastiglione added inline comments.
================
Comment at: lldb/source/Utility/ConstString.cpp:305
-void ConstString::SetString(const llvm::StringRef &s) {
- m_string = StringPool().GetConstCStringWithLength(s.data(), s.size());
+void ConstString::SetString(const llvm::StringRef s) {
+ m_string = StringPool().GetConstCStringWithStringRef(s);
----------------
bulbazord wrote:
> kastiglione wrote:
> > I think the `const` can be removed too, since `StringRef`s are immutable.
> Yeah, I can remove `const` and that should be fine too. But `StringRef`
> objects aren't immutable, you can modify them with methods like
> `consume_front` and `consume_back`.
thanks for pointing that out, I was thinking about the underlying `char *`,
which isn't mutable. Now that the `StringRef` is passed by copy, then the
caller's copy can't be modified.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D152010/new/
https://reviews.llvm.org/D152010
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
