mib added a comment. In D152012#4391336 <https://reviews.llvm.org/D152012#4391336>, @bulbazord wrote:
> The key here is that you're expanding the path and checking for the validity > before calling `CrashLogParser.create()` right? It looks like for the > `load_crashlog_in_scripted_process` case nothing has changed. If my > understanding is correct, then this looks good to me. Yep, I had to fixed this in the past for interactive mode in a07a751 <https://reviews.llvm.org/rGa07a75180c01a3f262b02f69ee5722080da74b84> but not for the regular crashlog command. This patch refactors it to cover both cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152012/new/ https://reviews.llvm.org/D152012 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
