[Lldb-commits] [PATCH] D152454: [lldb][test] LogTest: Fix stack overflow

[Michael Buch via Phabricator via lldb-commits]

Michael137 created this revision.
Herald added a project: All.
Michael137 requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.

The expected function name requires 18 bytes of storage.

Caught by the public ASAN buildbot


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D152454

Files:
  lldb/unittests/Utility/LogTest.cpp


Index: lldb/unittests/Utility/LogTest.cpp
===================================================================
--- lldb/unittests/Utility/LogTest.cpp
+++ lldb/unittests/Utility/LogTest.cpp
@@ -309,7 +309,7 @@
                               Err));
     llvm::StringRef Msg = logAndTakeOutputf("Hello World");
     char File[12];
-    char Function[17];
+    char Function[18];
 
     sscanf(Msg.str().c_str(),
            "%[^:]:%s                                 Hello World", File,



Index: lldb/unittests/Utility/LogTest.cpp
===================================================================
--- lldb/unittests/Utility/LogTest.cpp
+++ lldb/unittests/Utility/LogTest.cpp
@@ -309,7 +309,7 @@
                               Err));
     llvm::StringRef Msg = logAndTakeOutputf("Hello World");
     char File[12];
-    char Function[17];
+    char Function[18];
 
     sscanf(Msg.str().c_str(),
            "%[^:]:%s                                 Hello World", File,

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits