[Lldb-commits] [PATCH] D151597: [lldb][NFCI] Remove use of ConstString from IOHandler

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere added inline comments.


================
Comment at: lldb/include/lldb/Core/IOHandler.h:110
+  virtual llvm::StringRef GetControlSequence(char ch) {
+    return llvm::StringRef();
+  }
----------------
I would `return {}` or `return ""`. 


================
Comment at: lldb/include/lldb/Core/IOHandler.h:302-303
       : IOHandlerDelegate(completion),
-        m_end_line((end_line && end_line[0]) ? end_line : "") {}
+        m_end_line((end_line && end_line[0]) ? std::string(end_line) + "\n"
+                                             : "\n") {}
 
----------------
Can we make end_line a `StringRef`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151597/new/

https://reviews.llvm.org/D151597

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits