jasonmolenda added a comment. In D152861#4419197 <https://reviews.llvm.org/D152861#4419197>, @bulbazord wrote:
> I noticed you're pulling a lot of raw pointers out of shared pointers. Is > there a particular reason you're doing that? `operator bool` on > `std::shared_ptr` returns true if the held pointer is non-null. Nah, I didn't care much in these contexts whether I was holding a shared pointer from the lifetime point of view. You're right it's not going to be more efficient to do it this way, I might as well use the shared pointers I got back instead of extracting the pointer out of the SP. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152861/new/ https://reviews.llvm.org/D152861 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
