JDevlieghere added a comment.

In D152866#4419406 <https://reviews.llvm.org/D152866#4419406>, @bulbazord wrote:

> I like this idea quite a bit! I assume that when somebody hits a bug, they 
> can give us their diagnostics file and we will hopefully see the assertion 
> somewhere (if there was one)?

Unfortunate naming, but these are different diagnostics: these are errors and 
warnings that are emitted as events. What you're thinking of is the Diagnostic 
class.

- I should really rename one of them to avoid confusion.
- We could totally combine the two and emit a file with the lldbassert in the 
"diagnostics dir" that we generate on crash. I'll tackle that in a follow-up 
commit.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152866/new/

https://reviews.llvm.org/D152866

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to