bulbazord added inline comments.
================ Comment at: lldb/source/Utility/StructuredData.cpp:120 + return value->GetObjectForDotSeparatedPath(match.second); + } else if (GetType() == lldb::eStructuredDataTypeArray) { std::pair<llvm::StringRef, llvm::StringRef> match = path.split('['); ---------------- fdeazeve wrote: > Shouldn't we remove this `else`? Ah, the first `if` does return no matter what, so yeah this `else` isn't necessary. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154534/new/ https://reviews.llvm.org/D154534 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits