bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, jingham, clayborg. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits.
This has an `lldb_private` type in its parameter, it should be in `lldb-private-types.h` Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D155129 Files: lldb/include/lldb/Interpreter/CommandObject.h lldb/include/lldb/lldb-private-types.h lldb/include/lldb/lldb-types.h Index: lldb/include/lldb/lldb-types.h =================================================================== --- lldb/include/lldb/lldb-types.h +++ lldb/include/lldb/lldb-types.h @@ -71,8 +71,6 @@ typedef void (*LogOutputCallback)(const char *, void *baton); typedef bool (*CommandOverrideCallback)(void *baton, const char **argv); -typedef bool (*CommandOverrideCallbackWithResult)( - void *baton, const char **argv, lldb_private::CommandReturnObject &result); typedef bool (*ExpressionCancelCallback)(ExpressionEvaluationPhase phase, void *baton); Index: lldb/include/lldb/lldb-private-types.h =================================================================== --- lldb/include/lldb/lldb-private-types.h +++ lldb/include/lldb/lldb-private-types.h @@ -121,6 +121,8 @@ typedef void (*DebuggerDestroyCallback)(lldb::user_id_t debugger_id, void *baton); +typedef bool (*CommandOverrideCallbackWithResult)( + void *baton, const char **argv, lldb_private::CommandReturnObject &result); } // namespace lldb_private #endif // #if defined(__cplusplus) Index: lldb/include/lldb/Interpreter/CommandObject.h =================================================================== --- lldb/include/lldb/Interpreter/CommandObject.h +++ lldb/include/lldb/Interpreter/CommandObject.h @@ -294,8 +294,9 @@ m_command_override_baton = baton; } - void SetOverrideCallback(lldb::CommandOverrideCallbackWithResult callback, - void *baton) { + void + SetOverrideCallback(lldb_private::CommandOverrideCallbackWithResult callback, + void *baton) { m_command_override_callback = callback; m_command_override_baton = baton; } @@ -377,7 +378,7 @@ Flags m_flags; std::vector<CommandArgumentEntry> m_arguments; lldb::CommandOverrideCallback m_deprecated_command_override_callback; - lldb::CommandOverrideCallbackWithResult m_command_override_callback; + lldb_private::CommandOverrideCallbackWithResult m_command_override_callback; void *m_command_override_baton; bool m_is_user_command = false;
Index: lldb/include/lldb/lldb-types.h =================================================================== --- lldb/include/lldb/lldb-types.h +++ lldb/include/lldb/lldb-types.h @@ -71,8 +71,6 @@ typedef void (*LogOutputCallback)(const char *, void *baton); typedef bool (*CommandOverrideCallback)(void *baton, const char **argv); -typedef bool (*CommandOverrideCallbackWithResult)( - void *baton, const char **argv, lldb_private::CommandReturnObject &result); typedef bool (*ExpressionCancelCallback)(ExpressionEvaluationPhase phase, void *baton); Index: lldb/include/lldb/lldb-private-types.h =================================================================== --- lldb/include/lldb/lldb-private-types.h +++ lldb/include/lldb/lldb-private-types.h @@ -121,6 +121,8 @@ typedef void (*DebuggerDestroyCallback)(lldb::user_id_t debugger_id, void *baton); +typedef bool (*CommandOverrideCallbackWithResult)( + void *baton, const char **argv, lldb_private::CommandReturnObject &result); } // namespace lldb_private #endif // #if defined(__cplusplus) Index: lldb/include/lldb/Interpreter/CommandObject.h =================================================================== --- lldb/include/lldb/Interpreter/CommandObject.h +++ lldb/include/lldb/Interpreter/CommandObject.h @@ -294,8 +294,9 @@ m_command_override_baton = baton; } - void SetOverrideCallback(lldb::CommandOverrideCallbackWithResult callback, - void *baton) { + void + SetOverrideCallback(lldb_private::CommandOverrideCallbackWithResult callback, + void *baton) { m_command_override_callback = callback; m_command_override_baton = baton; } @@ -377,7 +378,7 @@ Flags m_flags; std::vector<CommandArgumentEntry> m_arguments; lldb::CommandOverrideCallback m_deprecated_command_override_callback; - lldb::CommandOverrideCallbackWithResult m_command_override_callback; + lldb_private::CommandOverrideCallbackWithResult m_command_override_callback; void *m_command_override_baton; bool m_is_user_command = false;
_______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits