jasonmolenda added a comment.

I ran the TargetTests under lldb to see (this test doesn't fail on my arm64 mac 
desktop ftr).   ASSERT_EQ calls `template <typename T1, typename T2> 
AssertionResult CmpHelperEQ()` and that calls `FileSpec::operator==` on my 
desktop.  Jonas suggested that we get the binary data dump of the FileSpec 
objects because there wasn't a method implemented in FileSpec that gtest knew 
to call to print the objects.  I originally thought ASSERT_EQ might be doing a 
binary comparison of the object bytes when I saw the failing msg on the arm64 
macos bot.

Would it be better to pass the `GetPath()` method on both of the FileSpec's we 
send to ASSERT_EQ so it is working with std::string's which it will know how to 
print if there is a comparison mismatch?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155333/new/

https://reviews.llvm.org/D155333

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to