DavidSpickett marked an inline comment as done. DavidSpickett added inline comments.
================ Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:1003 + // Bit 2 indicates whether the array storage is active (not yet implemented). + m_sme_ctrl_reg = m_sve_state == SVEState::Streaming; + return {}; ---------------- omjavaid wrote: > is there a need here to check if m_sve_state is valid? The only "invalid" state we can check at the moment is SVEState::Unknown. Which would translate here to a value of 0 in the register, which isn't incorrect, it's just pesimistic. By the time you're printing this register you'd likely have checked the state fully. Maybe it would come back as SVEState::Disabled, but in that case you wouldn't have SME anyway so this register isn't available to you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154927/new/ https://reviews.llvm.org/D154927 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits