bulbazord added inline comments.
================ Comment at: lldb/test/API/python_api/target-arch-from-module/TestTargetArchFromModule.py:39 + dwarfdump_cmd_output = subprocess.check_output( + ('/usr/bin/dwarfdump --uuid "%s"' % aout_exe), shell=True + ).decode("utf-8") ---------------- jasonmolenda wrote: > bulbazord wrote: > > I know this is already done in a few places but we should really use > > `llvm-dwarfdump` so this can be a more portable test... > Yeah Jonas made that point last week about another test I was getting the > uuid from a file. I don't know how to refer to something in the build > products directory in an API test like this, is that what you meant? It's > not installed on a standard macOS system in any path. Yeah I was referring to the build product `llvm-dwarfdump`. I did a quick search through the test suite but it doesn't look like we do this anywhere right now, so we'll need to figure out how to do it first. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157659/new/ https://reviews.llvm.org/D157659 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits