[Lldb-commits] [PATCH] D159076: [lldb] Add DynamicLoader for FreeBSD Kernel post-mortem debug facility

[Sheng-Yi Hung via Phabricator via lldb-commits]

aokblast updated this revision to Diff 554722.
aokblast added a comment.

Add "real comment" for commented code


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159076/new/

https://reviews.llvm.org/D159076

Files:
  
lldb/source/Plugins/DynamicLoader/FreeBSD-Kernel/DynamicLoaderFreeBSDKernel.cpp


Index: 
lldb/source/Plugins/DynamicLoader/FreeBSD-Kernel/DynamicLoaderFreeBSDKernel.cpp
===================================================================
--- 
lldb/source/Plugins/DynamicLoader/FreeBSD-Kernel/DynamicLoaderFreeBSDKernel.cpp
+++ 
lldb/source/Plugins/DynamicLoader/FreeBSD-Kernel/DynamicLoaderFreeBSDKernel.cpp
@@ -181,6 +181,7 @@
 
   if (header.getDataEncoding() == llvm::ELF::ELFDATA2MSB) {
     // TODO: swap byte order for big endian
+    return false;
   }
 
   return true;
@@ -321,6 +322,7 @@
 
   bool this_is_kernel = is_kernel(memory_module_sp.get());
 
+  // TODO: figure out why UUID is not same in FreeBSD Kernel dump
   // If the kernel specify what UUID should be found, we should match it
   // if (m_uuid.IsValid() && m_uuid != memory_module_sp->GetUUID()) {
   //     if (log) {
@@ -368,6 +370,7 @@
     s.Printf("Kernel UUID: %s\n", m_uuid.GetAsString().c_str());
     s.Printf("Load Address: 0x%" PRIx64 "\n", m_load_address);
 
+    // TODO: figure out why UUID is not same in FreeBSD Kernel dump
     // Delete more than one kernel image that accidently add by user
     // ModuleList incorrect_kernels;
     // for (ModuleSP module_sp : target.GetImages().Modules()) {



Index: lldb/source/Plugins/DynamicLoader/FreeBSD-Kernel/DynamicLoaderFreeBSDKernel.cpp
===================================================================
--- lldb/source/Plugins/DynamicLoader/FreeBSD-Kernel/DynamicLoaderFreeBSDKernel.cpp
+++ lldb/source/Plugins/DynamicLoader/FreeBSD-Kernel/DynamicLoaderFreeBSDKernel.cpp
@@ -181,6 +181,7 @@
 
   if (header.getDataEncoding() == llvm::ELF::ELFDATA2MSB) {
     // TODO: swap byte order for big endian
+    return false;
   }
 
   return true;
@@ -321,6 +322,7 @@
 
   bool this_is_kernel = is_kernel(memory_module_sp.get());
 
+  // TODO: figure out why UUID is not same in FreeBSD Kernel dump
   // If the kernel specify what UUID should be found, we should match it
   // if (m_uuid.IsValid() && m_uuid != memory_module_sp->GetUUID()) {
   //     if (log) {
@@ -368,6 +370,7 @@
     s.Printf("Kernel UUID: %s\n", m_uuid.GetAsString().c_str());
     s.Printf("Load Address: 0x%" PRIx64 "\n", m_load_address);
 
+    // TODO: figure out why UUID is not same in FreeBSD Kernel dump
     // Delete more than one kernel image that accidently add by user
     // ModuleList incorrect_kernels;
     // for (ModuleSP module_sp : target.GetImages().Modules()) {

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits