jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land.
LGTM this is just mechanical passing around of the user's setting though the layers. ================ Comment at: lldb/source/Plugins/Disassembler/LLVMC/DisassemblerLLVMC.h:76 bool m_data_from_file; + bool m_use_colors; // Save the AArch64 ADRP instruction word and address it was at, ---------------- Most of this patch uses `use_color`, but in this class there's a couple use of `colors`. I don't think it was an intentional difference, might as well make them all the same. In llvm the MCInstPrinter has a setUseColor but llvm::raw_string_ostream has a enable_colors, maybe that's where the plural came in. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159164/new/ https://reviews.llvm.org/D159164 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
