DavidSpickett added inline comments.
================ Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:1808-1810 + FileSpec dwo_name_next_to_binary(next_to_binary); + dwo_name_next_to_binary.AppendPathComponent(dwo_name); + dwo_paths.Append(dwo_name_next_to_binary); ---------------- clayborg wrote: > Should we only do this if "dwo_name" is relative? Also if "comp_dir" is > relative, do we want to add another path to search here? > Should we only do this if "dwo_name" is relative? Done. > Also if "comp_dir" is relative, do we want to add another path to search here? binary dir + relative comp dir is covered in the first set of checks around: ``` // if DW_AT_comp_dir is relative, it should be relative to the location... ``` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157609/new/ https://reviews.llvm.org/D157609 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
