https://github.com/bulbazord created
https://github.com/llvm/llvm-project/pull/66721
This is a follow-up to 14d95b26aee0ac0ac8a70252e8a3c7a986e0e812. I would have
changed it in that commit, but I don't build the intel-pt plugin so I didn't
see this until later.
>From 5adfbc5bd2c69422a6f03b94014eb0a96cf2ece6 Mon Sep 17 00:00:00 2001
From: Alex Langford <alangf...@apple.com>
Date: Mon, 18 Sep 2023 16:54:52 -0700
Subject: [PATCH] [lldb][NFCI] Remove unneeded ConstString from intel-pt plugin
This is a follow-up to 14d95b26aee0ac0ac8a70252e8a3c7a986e0e812. I would
have changed it in that commit, but I don't build the intel-pt plugin so
I didn't see this until later.
---
lldb/source/Plugins/Trace/intel-pt/TraceIntelPT.cpp | 4 ++--
lldb/source/Plugins/Trace/intel-pt/TraceIntelPT.h | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/lldb/source/Plugins/Trace/intel-pt/TraceIntelPT.cpp
b/lldb/source/Plugins/Trace/intel-pt/TraceIntelPT.cpp
index bcac731713bb24b..015faa89fcfada8 100644
--- a/lldb/source/Plugins/Trace/intel-pt/TraceIntelPT.cpp
+++ b/lldb/source/Plugins/Trace/intel-pt/TraceIntelPT.cpp
@@ -48,8 +48,8 @@ enum {
#include "TraceIntelPTPropertiesEnum.inc"
};
-ConstString TraceIntelPT::PluginProperties::GetSettingName() {
- return ConstString(TraceIntelPT::GetPluginNameStatic());
+llvm::StringRef TraceIntelPT::PluginProperties::GetSettingName() {
+ return TraceIntelPT::GetPluginNameStatic();
}
TraceIntelPT::PluginProperties::PluginProperties() : Properties() {
diff --git a/lldb/source/Plugins/Trace/intel-pt/TraceIntelPT.h
b/lldb/source/Plugins/Trace/intel-pt/TraceIntelPT.h
index 20faabdce790241..da9cefe9ed95d67 100644
--- a/lldb/source/Plugins/Trace/intel-pt/TraceIntelPT.h
+++ b/lldb/source/Plugins/Trace/intel-pt/TraceIntelPT.h
@@ -26,7 +26,7 @@ class TraceIntelPT : public Trace {
/// Properties to be used with the `settings` command.
class PluginProperties : public Properties {
public:
- static ConstString GetSettingName();
+ static llvm::StringRef GetSettingName();
PluginProperties();
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
