https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/68405
Fixes misleading comment introduced in
`f74aaca63202cabb512c78fe19196ff348d436a8`
>From 90db577879200ac4bd33f1078626ca54d8d1dc62 Mon Sep 17 00:00:00 2001
From: Michael Buch <michaelbuc...@gmail.com>
Date: Fri, 6 Oct 2023 11:38:03 +0100
Subject: [PATCH] [lldb][DWARFASTParserClang][NFC] Fix comment regarding static
data member detection
Fixes misleading comment introduced in
`f74aaca63202cabb512c78fe19196ff348d436a8`
---
lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
b/lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
index 6e13626d2894313..d0065896b0d2292 100644
--- a/lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
+++ b/lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
@@ -2878,8 +2878,8 @@ void DWARFASTParserClang::ParseSingleMember(
attrs.accessibility = eAccessNone;
// Handle static members, which are typically members without
- // locations. However, GCC *never* emits DW_AT_data_member_location
- // for static data members of unions.
+ // locations. However, GCC doesn't emit DW_AT_data_member_location
+ // for any union members (regardless of linkage).
// Non-normative text pre-DWARFv5 recommends marking static
// data members with an DW_AT_external flag. Clang emits this consistently
// whereas GCC emits it only for static data members if not part of an
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
