https://github.com/clayborg requested changes to this pull request.
With "lldb-vscode" (which might be "lldb-dap" soon) being a native DAP plug-in, I believe this means we can't set settings in the IDE itself if we are not a typescript DAP plug-in. How would anyone specify this extra option when running lldb-vscode? Is there a way to specify extra options that "lldb-vscode" should be launched with from the VS Code GUI? If so, how does this work? Or are you using this from a different IDE other than VS Code that allows you to specify extra options? The optimal solution for this in my mind would be to have some global settings that we can set in the VS Code GUI. I know there can be plug-in specific setting set as we allow a path to be specified in a custom DAP plug-in that points to the path to the "lldb-vscode" binary to actaully run instead of the one in the extensions folder. But I don't know if this can be done with a native only DAP plug-in (our custom solution has a typescript wrapper that eventually spawns "lldb-vscode" as we need to intercept and fix some packets, so we actaully have a typescript as our main DAP plug-in and we forward packets to lldb-vscode). The other way to fix this would be to add this as a launch config option. @walter-erquinigo this is how you did a previous fix for auto variable summaries being enabled. So we should really figure out our solution to having global settings and do them all consistently. https://github.com/llvm/llvm-project/pull/69238 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
