https://github.com/JDevlieghere requested changes to this pull request.

I already discussed this offline with Chelsea, but yeah I agree that "discrete" 
isn't very informative. Regardless of the name we pick, we should include an 
example too to help clarify its meaning. I'd also prefer to use an enum rather 
than a boolean for this, so that we don't have naked `true`/`false` all over 
the place or avoid inline comments. 

https://github.com/llvm/llvm-project/pull/69516
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to