medismailben wrote: > > I think I looked at every changed line, looks good to me overall. Found one > > place with a small style issue but it's not a blocker. Thanks! > > Thanks @bulbazord! Do you know why the `code_formatter` check/bot didn't flag > that or the other one-line `if` statements?
This could be because it's part of the LLVM style guide but not enforced in the `.clang-format`. Also looked at most of the lines, LGTM. I wonder however why did you decide to make 2 separate PRs for this ? Is there any reason for this ? It could have been 2 commits in the same PR. https://github.com/llvm/llvm-project/pull/69991 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
