================
@@ -57,7 +57,9 @@ std::unique_ptr<AppleDWARFIndex> AppleDWARFIndex::Create(
     return std::make_unique<AppleDWARFIndex>(
----------------
clayborg wrote:

DataExtractor objects don't always have shared buffers. I am guessing in this 
case it does have them, but you might throw in a `lldbassert(...)` just in case 
to make sure this doesn't regress in the future.  Maybe something like:
```
lldbassert(apple_names.GetSharedDataBuffer());
lldbassert(apple_namespaces.GetSharedDataBuffer());
lldbassert(apple_types.GetSharedDataBuffer());
lldbassert(apple_objc.GetSharedDataBuffer());
```

https://github.com/llvm/llvm-project/pull/71828
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to