=?utf-8?q?José?= L. Junior <josejun...@10xengineers.ai>,taalhaataahir0102
 <23100...@lums.edu.pk>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/69...@github.com>


taalhaataahir0102 wrote:

Hi David! Thanks, we'll update the required changes. Plus we just updated the 
test case:
Previously added this in the input file:

> So foo_bar would be matched twice by (foo|bar). Not sure if there's a symbol 
> in the program that'll fit that already. If not you could easily add one to 
> support this test case.

But we realized it was failing some other test case 
(`Commands/command-breakpoint-col.test`)

So we just used this technique instead: 

> You could even use main again. (ma|n\.o$). It might pick up other symbols so 
> just look for the main line and ignore anything else that comes up.

We'll incorporate the rest of the feedback soon. ;)

https://github.com/llvm/llvm-project/pull/69422
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to