================
@@ -1296,10 +1296,11 @@ enum CompletionType {
eRemoteDiskFileCompletion = (1u << 22),
eRemoteDiskDirectoryCompletion = (1u << 23),
eTypeCategoryNameCompletion = (1u << 24),
+ eThreadIDCompletion = (1u << 25),
----------------
clayborg wrote:
> @clayborg Is there anything special about `eCustomCompletion` being last? The
> comment in 1300-1302 seems to allude to this, but I don't see anything in the
> code base requiring this nor any other custom completions.
Yes, this is a problem. If there ever is a magic bit it should be something
like:
```
eCustomCompletion = (1u << 63) // Pick the last bit in a 64 bit value
```
But this is public API now which causes a problem for reasons I mentioned
before. @jimingham any ideas on if we care about adding the thread ID before
the `eCustomCompletion` from an API standpoint? lldb-rpc-server is the main
thing I worry about here since it sends enums as integers, not as strings which
are then converted back into integers.
https://github.com/llvm/llvm-project/pull/73596
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
