================ @@ -63,13 +68,30 @@ class Progress { /// /// @param [in] title The title of this progress activity. /// + /// @param [in] report_type Enum value indicating how the progress is being + /// reported. Progress reports considered "aggregate" are reports done for + /// operations that may happen multiple times during a debug session. + /// + /// For example, when a debug session is first started it needs to parse the + /// symbol tables for all files that were initially included and this + /// operation will deliver progress reports. If new dSYMs are added later + /// during the session then these will also be parsed and deliver more + /// progress reports. This type of operation would use the + /// eAggregateProgressReport enum. Using this enum would allow these progress + /// reports to be grouped together as one, even though their reports are + /// happening individually. + /// /// @param [in] total The total units of work to be done if specified, if /// set to UINT64_MAX then an indeterminate progress indicator should be /// displayed. /// /// @param [in] debugger An optional debugger pointer to specify that this /// progress is to be reported only to specific debuggers. - Progress(std::string title, uint64_t total = UINT64_MAX, + /// + Progress(std::string title, + ProgressReportType report_type = + ProgressReportType::eNonAggregateProgressReport, ---------------- clayborg wrote:
As long as `enum class ProgressReportType` can't implicitly convert an integer to a `ProgressReportType` this is safe to switch the order of arguments that were defaulted before (`total`). https://github.com/llvm/llvm-project/pull/69516 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits