https://github.com/clayborg requested changes to this pull request.

We should be modify `OptionArgParser::ToBoolean(...)` to return a 
`std::optional<bool>` instead of a local function. It already handles integer 
strings "0" and "1" correctly. Granted it doesn't allow "00" or "01" to be 
specified, but I am not sure we care. If we do, we can fix 
`OptionArgParser::ToBoolean(...)`

https://github.com/llvm/llvm-project/pull/79901
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to