llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-lldb Author: Chelsea Cassanova (chelcassanova) <details> <summary>Changes</summary> As part of the effort to improve progress reporting in LLDB (https://discourse.llvm.org/t/rfc-improve-lldb-progress-reporting/75717) we want a way to keep track of progress reports to see if they're ongoing. The ultimate goal is to use this information to essentially keep these reports alive using timeouts to more gracefully deliver these reports. To lay the groundwork to do this, this commit adds a map to progress reports that keeps track of each category of reports (using the changes from https://github.com/llvm/llvm-project/pull/77547) and uses a refcount to check if these reports are still considered active or not. A refcount of at least one indicates that the report is still active. I've added an enum to `Progress.h` to toggle whether this behaviour is used or not. By default it is not used, so this commit is marked as NFC. --- Full diff: https://github.com/llvm/llvm-project/pull/81026.diff 2 Files Affected: - (modified) lldb/include/lldb/Core/Progress.h (+10-1) - (modified) lldb/source/Core/Progress.cpp (+18-3) ``````````diff diff --git a/lldb/include/lldb/Core/Progress.h b/lldb/include/lldb/Core/Progress.h index 5d882910246054..fc921482ee12e0 100644 --- a/lldb/include/lldb/Core/Progress.h +++ b/lldb/include/lldb/Core/Progress.h @@ -12,6 +12,7 @@ #include "lldb/Utility/ConstString.h" #include "lldb/lldb-types.h" #include <atomic> +#include <map> #include <mutex> #include <optional> @@ -55,6 +56,10 @@ namespace lldb_private { class Progress { public: + enum { + eProgressLinearReports, + eProgressCoalecseReports, + }; /// Construct a progress object that will report information. /// /// The constructor will create a unique progress reporting object and @@ -71,7 +76,7 @@ class Progress { /// progress is to be reported only to specific debuggers. Progress(std::string title, std::string details = {}, std::optional<uint64_t> total = std::nullopt, - lldb_private::Debugger *debugger = nullptr); + lldb_private::Debugger *debugger = nullptr, bool type = Progress::eProgressLinearReports); /// Destroy the progress object. /// @@ -99,6 +104,9 @@ class Progress { private: void ReportProgress(); static std::atomic<uint64_t> g_id; + static std::atomic<uint64_t> g_refcount; + /// Map that tracks each progress object and if we've seen its start and stop events + static std::unordered_map<std::string, uint64_t> g_map; /// The title of the progress activity. std::string m_title; std::string m_details; @@ -117,6 +125,7 @@ class Progress { /// to ensure that we don't send progress updates after progress has /// completed. bool m_complete = false; + bool m_type; }; } // namespace lldb_private diff --git a/lldb/source/Core/Progress.cpp b/lldb/source/Core/Progress.cpp index 732efbc342b450..e79836033efe38 100644 --- a/lldb/source/Core/Progress.cpp +++ b/lldb/source/Core/Progress.cpp @@ -9,7 +9,6 @@ #include "lldb/Core/Progress.h" #include "lldb/Core/Debugger.h" -#include "lldb/Utility/StreamString.h" #include <optional> @@ -17,18 +16,27 @@ using namespace lldb; using namespace lldb_private; std::atomic<uint64_t> Progress::g_id(0); +std::atomic<uint64_t> Progress::g_refcount(1); +std::unordered_map<std::string, uint64_t> Progress::g_map = {}; Progress::Progress(std::string title, std::string details, std::optional<uint64_t> total, - lldb_private::Debugger *debugger) + lldb_private::Debugger *debugger, bool type) : m_title(title), m_details(details), m_id(++g_id), m_completed(0), - m_total(Progress::kNonDeterministicTotal) { + m_total(Progress::kNonDeterministicTotal), m_type(type) { if (total) m_total = *total; if (debugger) m_debugger_id = debugger->GetID(); std::lock_guard<std::mutex> guard(m_mutex); + + if (m_type == Progress::eProgressCoalecseReports) { + g_map.emplace(title, g_refcount); + + if (g_map.at(title) >= 1) + ++g_map.at(title); + } ReportProgress(); } @@ -38,6 +46,13 @@ Progress::~Progress() { std::lock_guard<std::mutex> guard(m_mutex); if (!m_completed) m_completed = m_total; + + if (m_type == Progress::eProgressCoalecseReports) { + --g_map.at(m_title); + if (g_map.at(m_title) == 0) + g_map.erase(m_title); + } + ReportProgress(); } `````````` </details> https://github.com/llvm/llvm-project/pull/81026 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
