jimingham wrote: This is responding to both Greg and Alex's "can't we also do X completion" comments:
It was clear that this was going to be a whole lot of change, some of it purely manual, and some requiring a little thought. To make it easier to review, I'm doing the work in stages. This first stage was: Make the base class handle homogenous arguments of one type, either with single repeat or multiple repeat commands. I made that change, and changed all the arguments that were obviously of that sort. If any of the extant completions were outside this scope, a little tricky, or caused a test failure I didn't understand, I left them for the second pass. That way we can review the ones that aren't mechanical without all the noise of the obvious ones. https://github.com/llvm/llvm-project/pull/82085 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits