================
@@ -1255,6 +1255,95 @@ lldb::SBFileSpec SBProcess::GetCoreFile() {
   return SBFileSpec(core_file);
 }
 
+addr_t SBProcess::GetAddressMask(AddressMaskType type,
+                                 AddressMaskRange addr_range) {
+  LLDB_INSTRUMENT_VA(this, type, addr_range);
+  addr_t default_mask = 0;
----------------
jasonmolenda wrote:

A mask value of 0 would be an invalid address mask -- no bits are used for 
addressing.  The variable name "default_mask" was a poor choice.  But 
explicitly returning LLDB_INVALID_ADDRESS_MASK if we don't find any value might 
be the correct choice, it would mean you passed an invalid enum argument (or 
the SBProcess can't access its Process)

https://github.com/llvm/llvm-project/pull/83095
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to