Author: Jason Molenda Date: 2024-03-26T10:54:26-07:00 New Revision: 29318abe1d2c55e8543255d70f26ac93261b74a4
URL: https://github.com/llvm/llvm-project/commit/29318abe1d2c55e8543255d70f26ac93261b74a4 DIFF: https://github.com/llvm/llvm-project/commit/29318abe1d2c55e8543255d70f26ac93261b74a4.diff LOG: [lldb] Remove test for add-symbol-file adds unwind source In commit 2f63718f8567413a1c596bda803663eb58d6da5a Author: Jason Molenda <jmole...@apple.com> Date: Tue Mar 26 09:07:15 2024 -0700 [lldb] Don't clear a Module's UnwindTable when adding a SymbolFile (#86603) I changed lldb to not clear a Module's UnwindTable when we add a SymbolFile to a binary, because the added benefit is marginal, and handling this reconstruction correctly is difficult. This test was written to explicitly create a test without unwind info in the binary, then add a symbol file with the unwind info, and check that it is present. I've intentionally broken this, so I'm removing the test. Added: Modified: Removed: lldb/test/Shell/SymbolFile/target-symbols-add-unwind.test ################################################################################ diff --git a/lldb/test/Shell/SymbolFile/target-symbols-add-unwind.test b/lldb/test/Shell/SymbolFile/target-symbols-add-unwind.test deleted file mode 100644 index 5420213d405e86..00000000000000 --- a/lldb/test/Shell/SymbolFile/target-symbols-add-unwind.test +++ /dev/null @@ -1,27 +0,0 @@ -# TODO: When it's possible to run "image show-unwind" without a running -# process, we can remove the unsupported line below, and hard-code an ELF -# triple in the test. -# UNSUPPORTED: system-windows, system-darwin - -# RUN: cd %T -# RUN: %clang_host %S/Inputs/target-symbols-add-unwind.c -g \ -# RUN: -fno-unwind-tables -fno-asynchronous-unwind-tables \ -# RUN: -o target-symbols-add-unwind.debug -# RUN: llvm-objcopy --strip-debug target-symbols-add-unwind.debug \ -# RUN: target-symbols-add-unwind.stripped -# RUN: %lldb target-symbols-add-unwind.stripped -s %s -o quit | FileCheck %s - -process launch --stop-at-entry -image show-unwind -n main -# CHECK-LABEL: image show-unwind -n main -# CHECK-NOT: debug_frame UnwindPlan: - -target symbols add -s target-symbols-add-unwind.stripped target-symbols-add-unwind.debug -# CHECK-LABEL: target symbols add -# CHECK: symbol file {{.*}} has been added to {{.*}} - -image show-unwind -n main -# CHECK-LABEL: image show-unwind -n main -# CHECK: debug_frame UnwindPlan: -# CHECK-NEXT: This UnwindPlan originally sourced from DWARF CFI -# CHECK-NEXT: This UnwindPlan is sourced from the compiler: yes. _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits