================ @@ -657,8 +657,11 @@ MinidumpFileBuilder::AddMemoryList(const lldb::ProcessSP &process_sp, auto data_up = std::make_unique<DataBufferHeap>(size, 0); const size_t bytes_read = process_sp->ReadMemory(addr, data_up->GetBytes(), size, error); - if (bytes_read == 0) + if (error.Fail() || bytes_read == 0) { ---------------- kusmour wrote:
Would that be too chatty? Maybe a warning msg if there's any and use log channel for more details? https://github.com/llvm/llvm-project/pull/88564 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits