labath wrote:

> > why not just call ModulesDidLoad and delegate this (and possibly other 
> > binary-just-loaded) behaviors to it?
> 
> That's what I did first, but it breaks the test 
> `TestModuleLoadedNotifys.ModuleLoadedNotifysTestCase.test_launch_notifications`
>  because of extra broadcaster event. So, I moved out the part just updating 
> breakpoints.

The point of the test is to ensure you don't get a hundred notifications, one 
for each module. Having one notification for ld.so, and 99 for the rest of the 
modules is ok. It should be fine to just update the test to match new reality.

https://github.com/llvm/llvm-project/pull/88792
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to