https://github.com/JDevlieghere requested changes to this pull request.
Based on the description it's not entirely clear to me what exactly you're
trying to achieve. You don't have a working directory, but presumably you still
have a platform name and a platform URL? In other words, I assume you want to
go into the `if configuration.lldb_platform_name` case? Please update the
description.
Looking at that code in more detail, I think the whole `if
configuration.lldb_platform_working_dir:` needs to be indented to be part of
the `if configuration.lldb_platform_name` case. It assumes
`lldb.remote_platform` which would be None if we didn't create the platform
above it.
In other words, I think the logic is supposed to be:
```
if configuration.lldb_platform_name:
## Create platform
if configuration.lldb_platform_url:
## Connect to platform URL
else:
configuration.lldb_platform_url = None
if configuration.lldb_platform_working_dir:
## Set working dir
else:
configuration.lldb_platform_working_dir = Nonej
else:
lldb.remote_platform = None
configuration.lldb_platform_name = None
configuration.lldb_platform_working_dir = None
configuration.lldb_platform_url = None
```
The two lines `lldb.remote_platform = None` and
`configuration.lldb_platform_name = None ` are no-ops as you wouldn't have
gotten there otherwise, but I think we can keep them to make it clear that
we're clearing everything.
https://github.com/llvm/llvm-project/pull/89768
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
