================
@@ -290,6 +290,36 @@ class StructuredData {
 
     void GetDescription(lldb_private::Stream &s) const override;
 
+    /// Creates an Array of substrings by splitting a string around the
+    /// occurrences of a separator character.
+    ///
+    /// Note:
+    /// * This is almost the same API and implementation as `StringRef::split`.
+    /// * Not depending on `StringRef::split` because it will involve a
+    ///   temporary `SmallVectorImpl`.
----------------
bulbazord wrote:

It sounds like this is justifying duplication for efficiency reasons. Have you 
actually observed that there is an actual gain in duplicating this 
functionality here? If you're doing this preemptively because it sounds like it 
should be faster, I would say measure or don't do it at all.

https://github.com/llvm/llvm-project/pull/90703
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to