================
@@ -1632,6 +1669,96 @@ DWARFASTParserClang::GetCPlusPlusQualifiedName(const
DWARFDIE &die) {
return qualified_name;
}
----------------
labath wrote:
I am bothered by this name. I would expect that something called
`FindDefinitionDIE` returns a DWARFDIE (or something along those lines).
Instead it returns bool, and appears to do a lot more than simply finding a DIE
(it constructs the full clang ast for it, iiuc).
How about, mirroring the SymbolFileDWARF apis this wraps, we call this
something like `FindDefinitionTypeForDIE` (and then actually have the function
return the parsed Type object)?
https://github.com/llvm/llvm-project/pull/90663
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
