llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) <details> <summary>Changes</summary> Alex pointed out in #<!-- -->91254 that we only need the custom target if we had more than one target depending on it. This isn't the case upstream, but on our downstream fork, we have a second dependency. Reintroduce the target so that everything can depend on that, without the single-dependency foot-gun. --- Full diff: https://github.com/llvm/llvm-project/pull/91390.diff 1 Files Affected: - (modified) lldb/source/API/CMakeLists.txt (+6-2) ``````````diff diff --git a/lldb/source/API/CMakeLists.txt b/lldb/source/API/CMakeLists.txt index 798a92874f13..aa31caddfde3 100644 --- a/lldb/source/API/CMakeLists.txt +++ b/lldb/source/API/CMakeLists.txt @@ -20,7 +20,7 @@ if(LLDB_ENABLE_LUA) set(lldb_lua_wrapper ${lua_bindings_dir}/LLDBWrapLua.cpp) endif() -# Target to generate SBLanguages.h from Dwarf.def. +# Generate SBLanguages.h from Dwarf.def. set(sb_languages_file ${CMAKE_CURRENT_BINARY_DIR}/../../include/lldb/API/SBLanguages.h) add_custom_command( @@ -33,6 +33,8 @@ add_custom_command( DEPENDS ${LLVM_MAIN_INCLUDE_DIR}/llvm/BinaryFormat/Dwarf.def WORKING_DIRECTORY ${LLVM_LIBRARY_OUTPUT_INTDIR} ) +add_custom_target(lldb-sbapi-dwarf-enums + DEPENDS ${sb_languages_file}) add_lldb_library(liblldb SHARED ${option_framework} SBAddress.cpp @@ -113,7 +115,9 @@ add_lldb_library(liblldb SHARED ${option_framework} SystemInitializerFull.cpp ${lldb_python_wrapper} ${lldb_lua_wrapper} - ${sb_languages_file} + + DEPENDS + lldb-sbapi-dwarf-enums LINK_LIBS lldbBreakpoint `````````` </details> https://github.com/llvm/llvm-project/pull/91390 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
