labath wrote: > > I am somewhat worried about this slowing down the actual operations it is > > reporting progress on. I didn't really measure this, but intuitively, I'd > > expect that a one of these operations (parsing/importing one type) would be > > pretty fast, and that the whole process takes so long simply because > > performing a very large number of these ops. > > Can you get some numbers on this? E.g., the number of events (per second?) > > that this generates, the timings of expression evaluation with/without the > > patch, or something like that? > > My understanding was that the progress increment is designed to be really > cheap (writing two pointers) and that it's up to presentation layer to decide > a t what frequency to update the UI.
Even if the actual publishing of the progress event was free, there's still appears to be quite a bit of code executed before we reach that point. For example, the "if sending progress" block in `UpdateImportProgress` is 15 lines long, it definitely looks like it can end up allocating memory, etc. https://github.com/llvm/llvm-project/pull/91452 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
