================
@@ -23,6 +23,8 @@ class Symtab {
 public:
   typedef std::vector<uint32_t> IndexCollection;
   typedef UniqueCStringMap<uint32_t> NameToIndexMap;
+  typedef std::map<lldb::addr_t, lldb_private::AddressClass>
+      FileAddressToAddressClassMap;
----------------
labath wrote:

This code depends on the map being sorted, which densemap isn't. According to 
the [llvm programmer's 
manual](https://llvm.org/docs/ProgrammersManual.html#map-like-containers-std-map-densemap-etc),
 the recommended data structure for a populate-then-query usage pattern is a 
sorted vector (though I would say that changing the data structure is not 
necessary for a patch like this).

https://github.com/llvm/llvm-project/pull/91603
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to