jimingham wrote: > Hm, so in that case should we focus on adding an `SBStream::GetUseColor` so > that the stream's colour settings can take precedence here?
That's the only way it makes sense to me. But if we are going to rely on the stream, we also have to be sure that we're setting the Streams "use color" correctly when we make them. That might be an annoying accounting exercise. I think an easier way allow streams to both get their "use color" from context and also override it for special purposes is to replace the use color bool with a "use color, don't use color, no opinion" enum. We'd make streams creation default to "no opinion". The SB API's would instead create them with "no use color" - and we should add an accessor to the SB API's. And then internally, "no opinion" means "consult the debugger" - but more generally it means "determine my use color value from context". That saves you from having to track down all the cases where streams were made and get their "use color" right. https://github.com/llvm/llvm-project/pull/91404 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
