slydiman wrote:

@labath, Sorry for not being clear with my comment. Let me re-phrase.

I think unconditionally setting the executable flag for everything installed by 
Platform::Install by default for all platforms is overkill.

BTW, there is no API to change this behavior, so `by default` means always.

Implementation details aside. Test files have the correct permissions set if 
the host allows it. Platform::Install copies the host file permissions to the 
target. This seems a correct behavior except for the case when the host has a 
smaller set of permissions than the target,  or permission sets on the host and 
the target do not match significantly. I'm aware of the only such case: Windows 
host and POSIX target. Do you know more?

https://github.com/llvm/llvm-project/pull/91887
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to