royitaqi wrote:

Hi @antmox,

I'm sorry that it broke the lldb-aarch64-windows build. My bad. Your fix makes 
sense, though I do have the same comment as @labath had, i.e. to move that 
typedef outside platform-specific region. From the latest comments in that PR 
it seems it's already got moved. If that's the case then I think we are all 
good.

My apologies that I didn't respond earlier - I was watching my email and the 
build bot (https://lab.llvm.org/buildbot/#/changes/134099), saw all green and I 
thought it's went well.   **Questions for my learning** (I'm noob to all 
these): I realize that the build bot I quoted didn't run the windows build you 
mentioned (lldb-aarch64-windows). This tells me that there are multiple build 
bots that I need to watch in the future. **Is there an exhaustive list 
somewhere?** Email obviously failed to inform me about the build break (i.e. I 
searched for "lldb-aarch64-windows" in my email and nothing except your 
message).

Thanks,
Roy

https://github.com/llvm/llvm-project/pull/89868
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to