jimingham wrote:

LGTM.  

We do offer SBValue::GetDescription, which uses a default 
DumpValueObjectOptions.  So it would be entirely reasonable to make an 
SBValueObjectDescriptionOptions (or maybe a shorter name?) and add 
SBValue::GetDescription(SBValueObjectDescriptionOptions) API.

But people can also cons up an equivalent Dump on their own using the other 
SBValue API's, so leaving the GetDescription as it is and doing the testing on 
the side like this is also fine.

https://github.com/llvm/llvm-project/pull/93158
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to