llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-lldb Author: Dmitry Vasilyev (slydiman) <details> <summary>Changes</summary> The target arch is `i386-pc-windows` after loading the dump. It updates to `i386-pc-windows-msvc` or `i386-pc-windows-gnu` in lldb\source\Plugins\Process\minidump\ProcessMinidump.cpp, line 218 ``` GetTarget().MergeArchitecture(module->GetArchitecture()); ``` But in case of the remote target (`remote-linux`) and the `Windows host` lldb executed the following commands at the beginning ``` platform select remote-linux platform connect connect://<ip>:<port> ``` and then the target arch is `i386-pc-windows-msvc` immediately after loading the dump. GetTarget().MergeArchitecture(module->GetArchitecture()) does not update it to `i386-pc-windows-gnu` when the module arch is `i386-pc-windows-gnu`. --- Full diff: https://github.com/llvm/llvm-project/pull/94165.diff 1 Files Affected: - (modified) lldb/test/Shell/Minidump/Windows/find-module.test (+2) ``````````diff diff --git a/lldb/test/Shell/Minidump/Windows/find-module.test b/lldb/test/Shell/Minidump/Windows/find-module.test index 7ac2f74f8039b..b3a7ec36520f0 100644 --- a/lldb/test/Shell/Minidump/Windows/find-module.test +++ b/lldb/test/Shell/Minidump/Windows/find-module.test @@ -1,6 +1,8 @@ Test that we correctly find a PE/COFF file in our executable search path, and use it when opening minidumps. +UNSUPPORTED: remote{{.*}} + RUN: yaml2obj %S/Inputs/find-module.exe.yaml -o %T/find-module.exe RUN: yaml2obj %S/Inputs/find-module.dmp.yaml -o %T/find-module.dmp RUN: %lldb -O "settings set target.exec-search-paths %T" \ `````````` </details> https://github.com/llvm/llvm-project/pull/94165 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
