JDevlieghere wrote: > The problem is that the console hasn't had enough time to collect the logs > after the process was terminated. This fix will keep collecting the logs > until the "exited with status..." log has been collected so that we can check > it. The caller could specify 10.0 seconds timeout instead of 1.0 second, but > this way the caller can exit earlier rather than forcefully waiting on the > timeout.
I wasn't suggesting to increase the timeout, but instead change the function to do exactly what you did here: have a smaller timeout and repeatedly check for a particular string, assuming that's a common pattern. The motivation being that other places where we do this probably also suffer from this, and it's just a matter of time before we see flakiness there too. https://github.com/llvm/llvm-project/pull/94494 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
