https://github.com/bulbazord approved this pull request.
LGTM to avoid the UB, I wouldn't block this because of a complex existential question. In general though, I don't really see the point in being able to convert a `ConstString` into a `std::string`? The whole point is that it uniques the string and manages its lifetime (which is effectively until the end of LLDB). I guess if you have a function/method that takes a `std::string` argument (or a reference to one) then this is useful... But why not just change the function (if it's in our control)? https://github.com/llvm/llvm-project/pull/95175 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
