https://github.com/sayhaan updated https://github.com/llvm/llvm-project/pull/96006
>From 2f1db023b70fc0bd8e0c220ebc966584bda13236 Mon Sep 17 00:00:00 2001 From: Sayhaan Siddiqui <sayh...@meta.com> Date: Mon, 17 Jun 2024 10:16:44 -0700 Subject: [PATCH 01/15] [BOLT][DWARF][NFC] Refactor updateDWARFObjectAddressRanges Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: https://phabricator.intern.facebook.com/D58679290 --- bolt/include/bolt/Core/DebugData.h | 2 + bolt/include/bolt/Rewrite/DWARFRewriter.h | 7 ++ bolt/lib/Core/DebugData.cpp | 7 ++ bolt/lib/Rewrite/DWARFRewriter.cpp | 110 +++++++++++------- bolt/test/X86/debug-fission-single-convert.s | 6 +- bolt/test/X86/dwarf4-df-dualcu.test | 34 +++--- .../X86/dwarf4-df-input-lowpc-ranges-cus.test | 78 +++++++------ .../X86/dwarf4-df-input-lowpc-ranges.test | 37 +++--- 8 files changed, 163 insertions(+), 118 deletions(-) diff --git a/bolt/include/bolt/Core/DebugData.h b/bolt/include/bolt/Core/DebugData.h index 585bafa088849..5c730e63ae0aa 100644 --- a/bolt/include/bolt/Core/DebugData.h +++ b/bolt/include/bolt/Core/DebugData.h @@ -210,6 +210,8 @@ class DebugRangesSectionWriter { static bool classof(const DebugRangesSectionWriter *Writer) { return Writer->getKind() == RangesWriterKind::DebugRangesWriter; } + + void updateRangeBuffer(std::unique_ptr<DebugBufferVector> &CUBuffer); /// Writes out range lists for a current CU being processed. void virtual finalizeSection(){}; diff --git a/bolt/include/bolt/Rewrite/DWARFRewriter.h b/bolt/include/bolt/Rewrite/DWARFRewriter.h index 8dec32de9008e..c97f25125c099 100644 --- a/bolt/include/bolt/Rewrite/DWARFRewriter.h +++ b/bolt/include/bolt/Rewrite/DWARFRewriter.h @@ -89,6 +89,13 @@ class DWARFRewriter { /// Store Rangelists writer for each DWO CU. RangeListsDWOWriers RangeListsWritersByCU; + using LegacyRangesDWOWriers = + std::unordered_map<uint64_t, std::unique_ptr<DebugRangesSectionWriter>>; + /// Store Rangelists writer for each DWO CU. + LegacyRangesDWOWriers LegacyRangesWritersByCU; + + std::unordered_map<uint64_t, DIE *> UpdatedDIEsByDWO; + std::mutex LocListDebugInfoPatchesMutex; /// Dwo id specific its RangesBase. diff --git a/bolt/lib/Core/DebugData.cpp b/bolt/lib/Core/DebugData.cpp index f502a50312470..8895b4923294a 100644 --- a/bolt/lib/Core/DebugData.cpp +++ b/bolt/lib/Core/DebugData.cpp @@ -177,6 +177,13 @@ uint64_t DebugRangesSectionWriter::getSectionOffset() { return SectionOffset; } +void DebugRangesSectionWriter::updateRangeBuffer(std::unique_ptr<DebugBufferVector> &CUBuffer) { + for(auto DebugInfo : *CUBuffer){ + RangesBuffer->push_back(DebugInfo); + } + SectionOffset = RangesBuffer->size(); +} + DebugAddrWriter *DebugRangeListsSectionWriter::AddrWriter = nullptr; uint64_t DebugRangeListsSectionWriter::addRanges( diff --git a/bolt/lib/Rewrite/DWARFRewriter.cpp b/bolt/lib/Rewrite/DWARFRewriter.cpp index 8814ebbd10aa5..e4e54f521ee19 100644 --- a/bolt/lib/Rewrite/DWARFRewriter.cpp +++ b/bolt/lib/Rewrite/DWARFRewriter.cpp @@ -646,6 +646,15 @@ void DWARFRewriter::updateDebugInfo() { } else { LocListWritersByCU[CUIndex] = std::make_unique<DebugLocWriter>(); + if (std::optional<uint64_t> DWOId = CU.getDWOId()) { + assert(LegacyRangesWritersByCU.count(*DWOId) == 0 && + "LegacyRangeLists writer for DWO unit already exists."); + auto LegacyRangesSectionWriterByCU = + std::make_unique<DebugRangesSectionWriter>(); + LegacyRangesSectionWriterByCU->initSection(CU); + LegacyRangesWritersByCU[*DWOId] = + std::move(LegacyRangesSectionWriterByCU); + } } return LocListWritersByCU[CUIndex++].get(); }; @@ -692,6 +701,7 @@ void DWARFRewriter::updateDebugInfo() { if (Unit->getVersion() >= 5) { TempRangesSectionWriter = RangeListsWritersByCU[*DWOId].get(); } else { + TempRangesSectionWriter = LegacyRangesWritersByCU[*DWOId].get(); RangesBase = RangesSectionWriter->getSectionOffset(); setDwoRangesBase(*DWOId, *RangesBase); } @@ -1270,10 +1280,14 @@ void DWARFRewriter::updateDWARFObjectAddressRanges( } if (RangesBaseInfo) { - DIEBldr.replaceValue(&Die, RangesBaseInfo.getAttribute(), - RangesBaseInfo.getForm(), - DIEInteger(static_cast<uint32_t>(*RangesBase))); - RangesBase = std::nullopt; + if (RangesBaseInfo.getAttribute() == dwarf::DW_AT_GNU_ranges_base) { + UpdatedDIEsByDWO[*Unit.getDWOId()] = &Die; + } else { + DIEBldr.replaceValue(&Die, RangesBaseInfo.getAttribute(), + RangesBaseInfo.getForm(), + DIEInteger(static_cast<uint32_t>(*RangesBase))); + RangesBase = std::nullopt; + } } } @@ -1290,11 +1304,9 @@ void DWARFRewriter::updateDWARFObjectAddressRanges( RangesAttrInfo.getForm() == dwarf::DW_FORM_sec_offset) NeedConverted = true; - uint64_t CurRangeBase = 0; if (Unit.isDWOUnit()) { - if (std::optional<uint64_t> DWOId = Unit.getDWOId()) - CurRangeBase = getDwoRangesBase(*DWOId); - else + std::optional<uint64_t> DWOId = Unit.getDWOId(); + if (!DWOId) errs() << "BOLT-WARNING: [internal-dwarf-error]: DWOId is not found " "for DWO Unit."; } @@ -1303,7 +1315,7 @@ void DWARFRewriter::updateDWARFObjectAddressRanges( DIEInteger(DebugRangesOffset)); else DIEBldr.replaceValue(&Die, dwarf::DW_AT_ranges, RangesAttrInfo.getForm(), - DIEInteger(DebugRangesOffset - CurRangeBase)); + DIEInteger(DebugRangesOffset)); if (!RangesBase) { if (LowPCAttrInfo && @@ -1322,8 +1334,9 @@ void DWARFRewriter::updateDWARFObjectAddressRanges( // DW_AT_GNU_ranges_base or DW_AT_rnglists_base doesn't exist. if (Unit.getVersion() <= 4) DIEBldr.addValue(&Die, dwarf::DW_AT_GNU_ranges_base, dwarf::DW_FORM_data4, - DIEInteger(*RangesBase)); - else if (Unit.getVersion() == 5) + DIEInteger(INT_MAX)); + UpdatedDIEsByDWO[*Unit.getDWOId()] = &Die; + } else if (Unit.getVersion() == 5) DIEBldr.addValue(&Die, dwarf::DW_AT_rnglists_base, dwarf::DW_FORM_sec_offset, DIEInteger(*RangesBase)); else @@ -1605,6 +1618,26 @@ void DWARFRewriter::finalizeCompileUnits(DIEBuilder &DIEBlder, DIEStreamer &Streamer, CUOffsetMap &CUMap, const std::list<DWARFUnit *> &CUs) { + size_t BufferSize = 0; + for (DWARFUnit *CU : CUs) { + if (CU->getVersion() != 4) + continue; + std::optional<uint64_t> DWOId; + DWOId = CU->getDWOId(); + if (DWOId) { + if (DIE *Die = UpdatedDIEsByDWO[*DWOId]) { + DIEValue DvalGNUBase = Die->findAttribute(dwarf::DW_AT_GNU_ranges_base); + DIEBlder.replaceValue(Die, dwarf::DW_AT_GNU_ranges_base, + DvalGNUBase.getForm(), DIEInteger(BufferSize)); + } + if (LegacyRangesWritersByCU[*DWOId]) { + std::unique_ptr<DebugBufferVector> RangesWritersContents = + LegacyRangesWritersByCU[*DWOId]->releaseBuffer(); + LegacyRangesSectionWriter->updateRangeBuffer(RangesWritersContents); + BufferSize += RangesWritersContents->size(); + } + } + } DIEBlder.generateAbbrevs(); DIEBlder.finish(); // generate debug_info and CUMap @@ -2263,7 +2296,6 @@ void DWARFRewriter::convertToRangesPatchDebugInfo( DWARFUnit &Unit, DIEBuilder &DIEBldr, DIE &Die, uint64_t RangesSectionOffset, DIEValue &LowPCAttrInfo, DIEValue &HighPCAttrInfo, std::optional<uint64_t> RangesBase) { - uint32_t BaseOffset = 0; dwarf::Form LowForm = LowPCAttrInfo.getForm(); dwarf::Attribute RangeBaseAttribute = dwarf::DW_AT_GNU_ranges_base; dwarf::Form RangesForm = dwarf::DW_FORM_sec_offset; @@ -2278,42 +2310,34 @@ void DWARFRewriter::convertToRangesPatchDebugInfo( Die.getTag() == dwarf::DW_TAG_skeleton_unit; if (!IsUnitDie) DIEBldr.deleteValue(&Die, LowPCAttrInfo.getAttribute()); - // In DWARF4 for DW_AT_low_pc in binary DW_FORM_addr is used. In the DWO - // section DW_FORM_GNU_addr_index is used. So for if we are converting - // DW_AT_low_pc/DW_AT_high_pc and see DW_FORM_GNU_addr_index. We are - // converting in DWO section, and DW_AT_ranges [DW_FORM_sec_offset] is - // relative to DW_AT_GNU_ranges_base. - if (LowForm == dwarf::DW_FORM_GNU_addr_index) { - // Ranges are relative to DW_AT_GNU_ranges_base. - uint64_t CurRangeBase = 0; - if (std::optional<uint64_t> DWOId = Unit.getDWOId()) { - CurRangeBase = getDwoRangesBase(*DWOId); - } - BaseOffset = CurRangeBase; - } else { - // In DWARF 5 we can have DW_AT_low_pc either as DW_FORM_addr, or - // DW_FORM_addrx. Former is when DW_AT_rnglists_base is present. Latter is - // when it's absent. - if (IsUnitDie) { - if (LowForm == dwarf::DW_FORM_addrx) { - const uint32_t Index = AddrWriter->getIndexFromAddress(0, Unit); - DIEBldr.replaceValue(&Die, LowPCAttrInfo.getAttribute(), - LowPCAttrInfo.getForm(), DIEInteger(Index)); - } else { - DIEBldr.replaceValue(&Die, LowPCAttrInfo.getAttribute(), - LowPCAttrInfo.getForm(), DIEInteger(0)); - } + + // In DWARF 5 we can have DW_AT_low_pc either as DW_FORM_addr, or + // DW_FORM_addrx. Former is when DW_AT_rnglists_base is present. Latter is + // when it's absent. + if (IsUnitDie) { + if (LowForm == dwarf::DW_FORM_addrx) { + const uint32_t Index = AddrWriter->getIndexFromAddress(0, Unit); + DIEBldr.replaceValue(&Die, LowPCAttrInfo.getAttribute(), + LowPCAttrInfo.getForm(), DIEInteger(Index)); + } else { + DIEBldr.replaceValue(&Die, LowPCAttrInfo.getAttribute(), + LowPCAttrInfo.getForm(), DIEInteger(0)); } - // Original CU didn't have DW_AT_*_base. We converted it's children (or - // dwo), so need to insert it into CU. - if (RangesBase) + } + // Original CU didn't have DW_AT_*_base. We converted it's children (or + // dwo), so need to insert it into CU. + if (RangesBase) { + if (Unit.getVersion() >= 5) { DIEBldr.addValue(&Die, RangeBaseAttribute, dwarf::DW_FORM_sec_offset, DIEInteger(*RangesBase)); + } else { + DIEBldr.addValue(&Die, RangeBaseAttribute, dwarf::DW_FORM_sec_offset, + DIEInteger(INT_MAX)); + UpdatedDIEsByDWO[*Unit.getDWOId()] = &Die; + } } - uint64_t RangeAttrVal = RangesSectionOffset - BaseOffset; - if (Unit.getVersion() >= 5) - RangeAttrVal = RangesSectionOffset; + uint64_t RangeAttrVal = RangesSectionOffset; // HighPC was conveted into DW_AT_ranges. // For DWARF5 we only access ranges through index. diff --git a/bolt/test/X86/debug-fission-single-convert.s b/bolt/test/X86/debug-fission-single-convert.s index 28fcb6686e0a2..4cd881740b2f8 100644 --- a/bolt/test/X86/debug-fission-single-convert.s +++ b/bolt/test/X86/debug-fission-single-convert.s @@ -31,11 +31,11 @@ # CHECK-DWO-DWO: 00000010 # CHECK-DWO-DWO: 00000050 # CHECK-DWO-DWO: DW_TAG_subprogram -# CHECK-DWO-DWO-NEXT: DW_AT_ranges [DW_FORM_sec_offset] (0x00000000 +# CHECK-DWO-DWO-NEXT: DW_AT_ranges [DW_FORM_sec_offset] (0x00000010 # CHECK-DWO-DWO: DW_TAG_subprogram -# CHECK-DWO-DWO-NEXT: DW_AT_ranges [DW_FORM_sec_offset] (0x00000020 +# CHECK-DWO-DWO-NEXT: DW_AT_ranges [DW_FORM_sec_offset] (0x00000030 # CHECK-DWO-DWO: DW_TAG_subprogram -# CHECK-DWO-DWO-NEXT: DW_AT_ranges [DW_FORM_sec_offset] (0x00000040 +# CHECK-DWO-DWO-NEXT: DW_AT_ranges [DW_FORM_sec_offset] (0x00000050 # CHECK-ADDR-SEC: .debug_addr contents: # CHECK-ADDR-SEC: 0x00000000: Addrs: [ diff --git a/bolt/test/X86/dwarf4-df-dualcu.test b/bolt/test/X86/dwarf4-df-dualcu.test index b690623b70d83..87bbe36da645c 100644 --- a/bolt/test/X86/dwarf4-df-dualcu.test +++ b/bolt/test/X86/dwarf4-df-dualcu.test @@ -38,35 +38,37 @@ ; BOLT: .debug_ranges ; BOLT-NEXT: 00000000 <End of list> ; BOLT-NEXT: 00000010 [[#%.16x,ADDR:]] [[#%.16x,ADDRB:]] +; BOLT-NEXT: 00000010 [[#%.16x,ADDR1:]] [[#%.16x,ADDR1B:]] ; BOLT-NEXT: 00000010 <End of list> -; BOLT-NEXT: 00000030 [[#%.16x,ADDR1:]] [[#%.16x,ADDR1B:]] -; BOLT-NEXT: 00000030 <End of list> +; BOLT-NEXT: 00000040 <End of list> ; BOLT-NEXT: 00000050 [[#%.16x,ADDR2:]] [[#%.16x,ADDR2B:]] -; BOLT-NEXT: 00000050 [[#%.16x,ADDR3:]] [[#%.16x,ADDR3B:]] ; BOLT-NEXT: 00000050 <End of list> -; BOLT-NEXT: 00000080 [[#%.16x,ADDR4:]] [[#%.16x,ADDR4B:]] -; BOLT-NEXT: 00000080 <End of list> -; BOLT-NEXT: 000000a0 [[#%.16x,ADDR5:]] [[#%.16x,ADDR5B:]] -; BOLT-NEXT: 000000a0 <End of list> +; BOLT-NEXT: 00000070 [[#%.16x,ADDR3:]] [[#%.16x,ADDR3B:]] +; BOLT-NEXT: 00000070 <End of list> +; BOLT-NEXT: 00000090 [[#%.16x,ADDR4:]] [[#%.16x,ADDR4B:]] +; BOLT-NEXT: 00000090 <End of list> +; BOLT-NEXT: 000000b0 <End of list> +; BOLT-NEXT: 000000c0 [[#%.16x,ADDR5:]] [[#%.16x,ADDR5B:]] +; BOLT-NEXT: 000000c0 <End of list> ; BOLT: DW_TAG_compile_unit ; BOLT: DW_AT_GNU_dwo_name [DW_FORM_strp] ( .debug_str[0x00000016] = "main.dwo.dwo") ; BOLT-NEXT: DW_AT_GNU_dwo_id ; BOLT-NEXT: DW_AT_low_pc [DW_FORM_addr] (0x0000000000000000) -; BOLT-NEXT: DW_AT_ranges [DW_FORM_sec_offset] (0x00000050 -; BOLT-NEXT: [0x[[#ADDR2]], 0x[[#ADDR2B]]) -; BOLT-NEXT: [0x[[#ADDR3]], 0x[[#ADDR3B]])) +; BOLT-NEXT: DW_AT_ranges [DW_FORM_sec_offset] (0x00000010 +; BOLT-NEXT: [0x[[#ADDR]], 0x[[#ADDRB]]) +; BOLT-NEXT: [0x[[#ADDR1]], 0x[[#ADDR1B]])) ; BOLT-NEXT: DW_AT_GNU_addr_base [DW_FORM_sec_offset] (0x00000000) -; BOLT-NEXT: DW_AT_GNU_ranges_base [DW_FORM_sec_offset] (0x00000010) +; BOLT-NEXT: DW_AT_GNU_ranges_base [DW_FORM_sec_offset] (0x00000000) ; BOLT-NEXT: Compile ; BOLT: DW_TAG_compile_unit ; BOLT: DW_AT_GNU_dwo_name [DW_FORM_strp] ( .debug_str[0x00000023] = "helper.dwo.dwo") ; BOLT-NEXT: DW_AT_GNU_dwo_id ; BOLT-NEXT: DW_AT_low_pc [DW_FORM_addr] (0x0000000000000000) -; BOLT-NEXT: DW_AT_ranges [DW_FORM_sec_offset] (0x000000a0 +; BOLT-NEXT: DW_AT_ranges [DW_FORM_sec_offset] (0x00000090 ; BOLT-NEXT: [0x[[#ADDR5]], 0x[[#ADDR5B]]) ; BOLT-NEXT: DW_AT_GNU_addr_base [DW_FORM_sec_offset] (0x00000010) -; BOLT-NEXT: DW_AT_GNU_ranges_base [DW_FORM_sec_offset] (0x00000080) +; BOLT-NEXT: DW_AT_GNU_ranges_base [DW_FORM_sec_offset] (0x00000000) ; PRE-BOLT-DWO-MAIN: version = 0x0004 ; PRE-BOLT-DWO-MAIN: DW_TAG_compile_unit @@ -113,13 +115,13 @@ ; BOLT-DWO-MAIN-NEXT: DW_AT_decl_line ; BOLT-DWO-MAIN-NEXT: DW_AT_location [DW_FORM_exprloc] (DW_OP_GNU_addr_index 0x1) ; BOLT-DWO-MAIN: DW_TAG_subprogram [4] -; BOLT-DWO-MAIN-NEXT: DW_AT_ranges [DW_FORM_sec_offset] (0x00000000 +; BOLT-DWO-MAIN-NEXT: DW_AT_ranges [DW_FORM_sec_offset] (0x00000010 ; BOLT-DWO-MAIN-NEXT: ) ; BOLT-DWO-MAIN-NEXT: DW_AT_frame_base ; BOLT-DWO-MAIN-NEXT: DW_AT_linkage_name [DW_FORM_GNU_str_index] (indexed (00000003) string = "_Z3usePiS_") ; BOLT-DWO-MAIN-NEXT: DW_AT_name [DW_FORM_GNU_str_index] (indexed (00000004) string = "use") ; BOLT-DWO-MAIN: DW_TAG_subprogram [6] -; BOLT-DWO-MAIN-NEXT: DW_AT_ranges [DW_FORM_sec_offset] (0x00000020 +; BOLT-DWO-MAIN-NEXT: DW_AT_ranges [DW_FORM_sec_offset] (0x00000030 ; BOLT-DWO-MAIN-NEXT: ) ; BOLT-DWO-MAIN-NEXT: DW_AT_frame_base [DW_FORM_exprloc] (DW_OP_reg6 RBP) ; BOLT-DWO-MAIN-NEXT: DW_AT_name [DW_FORM_GNU_str_index] (indexed (00000005) string = "main") @@ -160,4 +162,4 @@ ; BOLT-DWO-HELPER-NEXT: DW_AT_decl_line ; BOLT-DWO-HELPER-NEXT: DW_AT_location [DW_FORM_exprloc] (DW_OP_GNU_addr_index 0x1) ; BOLT-DWO-HELPER: DW_TAG_subprogram [4] -; BOLT-DWO-HELPER-NEXT: DW_AT_ranges [DW_FORM_sec_offset] (0x00000000 +; BOLT-DWO-HELPER-NEXT: DW_AT_ranges [DW_FORM_sec_offset] (0x00000010 diff --git a/bolt/test/X86/dwarf4-df-input-lowpc-ranges-cus.test b/bolt/test/X86/dwarf4-df-input-lowpc-ranges-cus.test index c9abd02bbb7d9..8dae05db12d73 100644 --- a/bolt/test/X86/dwarf4-df-input-lowpc-ranges-cus.test +++ b/bolt/test/X86/dwarf4-df-input-lowpc-ranges-cus.test @@ -17,45 +17,47 @@ ; BOLT: .debug_ranges ; BOLT-NEXT: 00000000 <End of list> -; BOLT-NEXT: 00000010 -; BOLT-NEXT: 00000010 -; BOLT-NEXT: 00000010 +; BOLT-NEXT: 00000010 [[#%.16x,ADDR1:]] [[#%.16x,ADDRB1:]] +; BOLT-NEXT: 00000010 [[#%.16x,ADDR2:]] [[#%.16x,ADDRB2:]] +; BOLT-NEXT: 00000010 [[#%.16x,ADDR3:]] [[#%.16x,ADDRB3:]] +; BOLT-NEXT: 00000010 [[#%.16x,ADDR4:]] [[#%.16x,ADDRB4:]] +; BOLT-NEXT: 00000010 [[#%.16x,ADDR5:]] [[#%.16x,ADDRB5:]] +; BOLT-NEXT: 00000010 [[#%.16x,ADDR6:]] [[#%.16x,ADDRB6:]] +; BOLT-NEXT: 00000010 [[#%.16x,ADDR7:]] [[#%.16x,ADDRB7:]] ; BOLT-NEXT: 00000010 <End of list> -; BOLT-NEXT: 00000050 -; BOLT-NEXT: 00000050 -; BOLT-NEXT: 00000050 -; BOLT-NEXT: 00000050 <End of list> -; BOLT-NEXT: 00000090 [[#%.16x,ADDR1:]] [[#%.16x,ADDRB1:]] -; BOLT-NEXT: 00000090 [[#%.16x,ADDR2:]] [[#%.16x,ADDRB2:]] -; BOLT-NEXT: 00000090 [[#%.16x,ADDR3:]] [[#%.16x,ADDRB3:]] -; BOLT-NEXT: 00000090 [[#%.16x,ADDR4:]] [[#%.16x,ADDRB4:]] -; BOLT-NEXT: 00000090 [[#%.16x,ADDR5:]] [[#%.16x,ADDRB5:]] -; BOLT-NEXT: 00000090 [[#%.16x,ADDR6:]] [[#%.16x,ADDRB6:]] -; BOLT-NEXT: 00000090 [[#%.16x,ADDR7:]] [[#%.16x,ADDRB7:]] ; BOLT-NEXT: 00000090 <End of list> -; BOLT-NEXT: 00000110 -; BOLT-NEXT: 00000110 -; BOLT-NEXT: 00000110 -; BOLT-NEXT: 00000110 <End of list> -; BOLT-NEXT: 00000150 -; BOLT-NEXT: 00000150 -; BOLT-NEXT: 00000150 -; BOLT-NEXT: 00000150 <End of list> -; BOLT-NEXT: 00000190 [[#%.16x,ADDR8:]] [[#%.16x,ADDRB8:]] -; BOLT-NEXT: 00000190 [[#%.16x,ADDR9:]] [[#%.16x,ADDRB9:]] -; BOLT-NEXT: 00000190 [[#%.16x,ADDR10:]] [[#%.16x,ADDRB10:]] -; BOLT-NEXT: 00000190 [[#%.16x,ADDR11:]] [[#%.16x,ADDRB11:]] -; BOLT-NEXT: 00000190 [[#%.16x,ADDR12:]] [[#%.16x,ADDRB12:]] -; BOLT-NEXT: 00000190 [[#%.16x,ADDR13:]] [[#%.16x,ADDRB13:]] -; BOLT-NEXT: 00000190 [[#%.16x,ADDR14:]] [[#%.16x,ADDRB14:]] -; BOLT-NEXT: 00000190 <End of list> +; BOLT-NEXT: 000000a0 [[#%.16x,ADDR1:]] [[#%.16x,ADDRB1:]] +; BOLT-NEXT: 000000a0 [[#%.16x,ADDR2:]] [[#%.16x,ADDRB2:]] +; BOLT-NEXT: 000000a0 [[#%.16x,ADDR3:]] [[#%.16x,ADDRB3:]] +; BOLT-NEXT: 000000a0 <End of list> +; BOLT-NEXT: 000000e0 [[#%.16x,ADDR5:]] [[#%.16x,ADDRB5:]] +; BOLT-NEXT: 000000e0 [[#%.16x,ADDR6:]] [[#%.16x,ADDRB6:]] +; BOLT-NEXT: 000000e0 [[#%.16x,ADDR7:]] [[#%.16x,ADDRB7:]] +; BOLT-NEXT: 000000e0 <End of list> +; BOLT-NEXT: 00000120 [[#%.16x,ADDR8:]] [[#%.16x,ADDRB8:]] +; BOLT-NEXT: 00000120 [[#%.16x,ADDR9:]] [[#%.16x,ADDRB9:]] +; BOLT-NEXT: 00000120 [[#%.16x,ADDR10:]] [[#%.16x,ADDRB10:]] +; BOLT-NEXT: 00000120 [[#%.16x,ADDR11:]] [[#%.16x,ADDRB11:]] +; BOLT-NEXT: 00000120 [[#%.16x,ADDR12:]] [[#%.16x,ADDRB12:]] +; BOLT-NEXT: 00000120 [[#%.16x,ADDR13:]] [[#%.16x,ADDRB13:]] +; BOLT-NEXT: 00000120 [[#%.16x,ADDR14:]] [[#%.16x,ADDRB14:]] +; BOLT-NEXT: 00000120 <End of list> +; BOLT-NEXT: 000001a0 <End of list> +; BOLT-NEXT: 000001b0 [[#%.16x,ADDR8:]] [[#%.16x,ADDRB8:]] +; BOLT-NEXT: 000001b0 [[#%.16x,ADDR9:]] [[#%.16x,ADDRB9:]] +; BOLT-NEXT: 000001b0 [[#%.16x,ADDR10:]] [[#%.16x,ADDRB10:]] +; BOLT-NEXT: 000001b0 <End of list> +; BOLT-NEXT: 000001f0 [[#%.16x,ADDR12:]] [[#%.16x,ADDRB12:]] +; BOLT-NEXT: 000001f0 [[#%.16x,ADDR13:]] [[#%.16x,ADDRB13:]] +; BOLT-NEXT: 000001f0 [[#%.16x,ADDR14:]] [[#%.16x,ADDRB14:]] +; BOLT-NEXT: 000001f0 <End of list> ; BOLT: DW_TAG_compile_unit ; BOLT: DW_AT_GNU_dwo_name [DW_FORM_strp] ( .debug_str[0x{{[0-9a-fA-F]+}}] = "main.dwo.dwo") ; BOLT-NEXT: DW_AT_GNU_dwo_id -; BOLT-NEXT: DW_AT_GNU_ranges_base [DW_FORM_sec_offset] (0x00000010) +; BOLT-NEXT: DW_AT_GNU_ranges_base [DW_FORM_sec_offset] (0x00000000) ; BOLT-NEXT: DW_AT_low_pc [DW_FORM_addr] (0x0000000000000000) -; BOLT-NEXT: DW_AT_ranges [DW_FORM_sec_offset] (0x00000090 +; BOLT-NEXT: DW_AT_ranges [DW_FORM_sec_offset] (0x00000010 ; BOLT-NEXT: [0x[[#ADDR1]], 0x[[#ADDRB1]]) ; BOLT-NEXT: [0x[[#ADDR2]], 0x[[#ADDRB2]]) ; BOLT-NEXT: [0x[[#ADDR3]], 0x[[#ADDRB3]]) @@ -68,9 +70,9 @@ ; BOLT: DW_TAG_compile_unit ; BOLT: DW_AT_GNU_dwo_name [DW_FORM_strp] ( .debug_str[0x{{[0-9a-fA-F]+}}] = "mainOther.dwo.dwo") ; BOLT-NEXT: DW_AT_GNU_dwo_id -; BOLT-NEXT: DW_AT_GNU_ranges_base [DW_FORM_sec_offset] (0x00000110) +; BOLT-NEXT: DW_AT_GNU_ranges_base [DW_FORM_sec_offset] (0x00000000) ; BOLT-NEXT: DW_AT_low_pc [DW_FORM_addr] (0x0000000000000000) -; BOLT-NEXT: DW_AT_ranges [DW_FORM_sec_offset] (0x00000190 +; BOLT-NEXT: DW_AT_ranges [DW_FORM_sec_offset] (0x00000120 ; BOLT-NEXT: [0x[[#ADDR8]], 0x[[#ADDRB8]]) ; BOLT-NEXT: [0x[[#ADDR9]], 0x[[#ADDRB9]]) ; BOLT-NEXT: [0x[[#ADDR10]], 0x[[#ADDRB10]]) @@ -81,17 +83,17 @@ ; BOLT-NEXT: DW_AT_GNU_addr_base [DW_FORM_sec_offset] (0x00000018) ; BOLT-DWO-MAIN: DW_TAG_subprogram -; BOLT-DWO-MAIN-NEXT: DW_AT_ranges [DW_FORM_sec_offset] (0x00000000 +; BOLT-DWO-MAIN-NEXT: DW_AT_ranges [DW_FORM_sec_offset] (0x00000010 ; BOLT-DWO-MAIN: DW_TAG_subprogram ; BOLT-DWO-MAIN: DW_TAG_subprogram ; BOLT-DWO-MAIN: DW_TAG_subprogram ; BOLT-DWO-MAIN: DW_TAG_subprogram -; BOLT-DWO-MAIN-NEXT: DW_AT_ranges [DW_FORM_sec_offset] (0x00000040 +; BOLT-DWO-MAIN-NEXT: DW_AT_ranges [DW_FORM_sec_offset] (0x00000050 ; BOLT-DWO-MAIN: DW_TAG_subprogram -; BOLT-DWO-MAIN-NEXT: DW_AT_ranges [DW_FORM_sec_offset] (0x00000000 +; BOLT-DWO-MAIN-NEXT: DW_AT_ranges [DW_FORM_sec_offset] (0x00000010 ; BOLT-DWO-MAIN: DW_TAG_subprogram ; BOLT-DWO-MAIN: DW_TAG_subprogram ; BOLT-DWO-MAIN: DW_TAG_subprogram ; BOLT-DWO-MAIN: DW_TAG_subprogram -; BOLT-DWO-MAIN-NEXT: DW_AT_ranges [DW_FORM_sec_offset] (0x00000040 +; BOLT-DWO-MAIN-NEXT: DW_AT_ranges [DW_FORM_sec_offset] (0x00000050 diff --git a/bolt/test/X86/dwarf4-df-input-lowpc-ranges.test b/bolt/test/X86/dwarf4-df-input-lowpc-ranges.test index 276bea4ba0c1c..908ef429b83ab 100644 --- a/bolt/test/X86/dwarf4-df-input-lowpc-ranges.test +++ b/bolt/test/X86/dwarf4-df-input-lowpc-ranges.test @@ -15,29 +15,30 @@ ; BOLT: .debug_ranges ; BOLT-NEXT: 00000000 <End of list> -; BOLT-NEXT: 00000010 -; BOLT-NEXT: 00000010 -; BOLT-NEXT: 00000010 +; BOLT-NEXT: 00000010 [[#%.16x,ADDR1:]] [[#%.16x,ADDRB1:]] +; BOLT-NEXT: 00000010 [[#%.16x,ADDR2:]] [[#%.16x,ADDRB2:]] +; BOLT-NEXT: 00000010 [[#%.16x,ADDR3:]] [[#%.16x,ADDRB3:]] +; BOLT-NEXT: 00000010 [[#%.16x,ADDR4:]] [[#%.16x,ADDRB4:]] +; BOLT-NEXT: 00000010 [[#%.16x,ADDR5:]] [[#%.16x,ADDRB5:]] +; BOLT-NEXT: 00000010 [[#%.16x,ADDR6:]] [[#%.16x,ADDRB6:]] +; BOLT-NEXT: 00000010 [[#%.16x,ADDR7:]] [[#%.16x,ADDRB7:]] ; BOLT-NEXT: 00000010 <End of list> -; BOLT-NEXT: 00000050 -; BOLT-NEXT: 00000050 -; BOLT-NEXT: 00000050 -; BOLT-NEXT: 00000050 <End of list> -; BOLT-NEXT: 00000090 [[#%.16x,ADDR1:]] [[#%.16x,ADDRB1:]] -; BOLT-NEXT: 00000090 [[#%.16x,ADDR2:]] [[#%.16x,ADDRB2:]] -; BOLT-NEXT: 00000090 [[#%.16x,ADDR3:]] [[#%.16x,ADDRB3:]] -; BOLT-NEXT: 00000090 [[#%.16x,ADDR4:]] [[#%.16x,ADDRB4:]] -; BOLT-NEXT: 00000090 [[#%.16x,ADDR5:]] [[#%.16x,ADDRB5:]] -; BOLT-NEXT: 00000090 [[#%.16x,ADDR6:]] [[#%.16x,ADDRB6:]] -; BOLT-NEXT: 00000090 [[#%.16x,ADDR7:]] [[#%.16x,ADDRB7:]] ; BOLT-NEXT: 00000090 <End of list> +; BOLT-NEXT: 000000a0 [[#%.16x,ADDR1:]] [[#%.16x,ADDRB1:]] +; BOLT-NEXT: 000000a0 [[#%.16x,ADDR2:]] [[#%.16x,ADDRB2:]] +; BOLT-NEXT: 000000a0 [[#%.16x,ADDR3:]] [[#%.16x,ADDRB3:]] +; BOLT-NEXT: 000000a0 <End of list> +; BOLT-NEXT: 000000e0 [[#%.16x,ADDR5:]] [[#%.16x,ADDRB5:]] +; BOLT-NEXT: 000000e0 [[#%.16x,ADDR6:]] [[#%.16x,ADDRB6:]] +; BOLT-NEXT: 000000e0 [[#%.16x,ADDR7:]] [[#%.16x,ADDRB7:]] +; BOLT-NEXT: 000000e0 <End of list> ; BOLT: DW_TAG_compile_unit ; BOLT: DW_AT_GNU_dwo_name [DW_FORM_strp] ( .debug_str[0x{{[0-9a-fA-F]+}}] = "main.dwo.dwo") ; BOLT-NEXT: DW_AT_GNU_dwo_id -; BOLT-NEXT: DW_AT_GNU_ranges_base [DW_FORM_sec_offset] (0x00000010) +; BOLT-NEXT: DW_AT_GNU_ranges_base [DW_FORM_sec_offset] (0x00000000) ; BOLT-NEXT: DW_AT_low_pc [DW_FORM_addr] (0x0000000000000000) -; BOLT-NEXT: DW_AT_ranges [DW_FORM_sec_offset] (0x00000090 +; BOLT-NEXT: DW_AT_ranges [DW_FORM_sec_offset] (0x00000010 ; BOLT-NEXT: [0x[[#ADDR1]], 0x[[#ADDRB1]]) ; BOLT-NEXT: [0x[[#ADDR2]], 0x[[#ADDRB2]]) ; BOLT-NEXT: [0x[[#ADDR3]], 0x[[#ADDRB3]]) @@ -48,9 +49,9 @@ ; BOLT-NEXT: DW_AT_GNU_addr_base [DW_FORM_sec_offset] (0x00000000) ; BOLT-DWO-MAIN: DW_TAG_subprogram -; BOLT-DWO-MAIN-NEXT: DW_AT_ranges [DW_FORM_sec_offset] (0x00000000 +; BOLT-DWO-MAIN-NEXT: DW_AT_ranges [DW_FORM_sec_offset] (0x00000010 ; BOLT-DWO-MAIN: DW_TAG_subprogram ; BOLT-DWO-MAIN: DW_TAG_subprogram ; BOLT-DWO-MAIN: DW_TAG_subprogram ; BOLT-DWO-MAIN: DW_TAG_subprogram -; BOLT-DWO-MAIN-NEXT: DW_AT_ranges [DW_FORM_sec_offset] (0x00000040 +; BOLT-DWO-MAIN-NEXT: DW_AT_ranges [DW_FORM_sec_offset] (0x00000050 >From d2d3322eee68e2b7844c1bdc0b5a9fc40df7428a Mon Sep 17 00:00:00 2001 From: Sayhaan Siddiqui <sayh...@meta.com> Date: Tue, 18 Jun 2024 16:04:02 -0700 Subject: [PATCH 02/15] Formatting change --- bolt/lib/Rewrite/DWARFRewriter.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bolt/lib/Rewrite/DWARFRewriter.cpp b/bolt/lib/Rewrite/DWARFRewriter.cpp index e4e54f521ee19..f831e7188da32 100644 --- a/bolt/lib/Rewrite/DWARFRewriter.cpp +++ b/bolt/lib/Rewrite/DWARFRewriter.cpp @@ -1332,7 +1332,7 @@ void DWARFRewriter::updateDWARFObjectAddressRanges( // If we are at this point we are in the CU/Skeleton CU, and // DW_AT_GNU_ranges_base or DW_AT_rnglists_base doesn't exist. - if (Unit.getVersion() <= 4) + if (Unit.getVersion() <= 4) { DIEBldr.addValue(&Die, dwarf::DW_AT_GNU_ranges_base, dwarf::DW_FORM_data4, DIEInteger(INT_MAX)); UpdatedDIEsByDWO[*Unit.getDWOId()] = &Die; >From 893818a2abc2e080f7f4cde0eb4c2fcbf4f68d45 Mon Sep 17 00:00:00 2001 From: Sayhaan Siddiqui <sayh...@meta.com> Date: Thu, 20 Jun 2024 09:30:56 -0700 Subject: [PATCH 03/15] Formatting changes --- bolt/include/bolt/Rewrite/DWARFRewriter.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bolt/include/bolt/Rewrite/DWARFRewriter.h b/bolt/include/bolt/Rewrite/DWARFRewriter.h index c97f25125c099..0c5dd8e6c2f9a 100644 --- a/bolt/include/bolt/Rewrite/DWARFRewriter.h +++ b/bolt/include/bolt/Rewrite/DWARFRewriter.h @@ -91,7 +91,7 @@ class DWARFRewriter { using LegacyRangesDWOWriers = std::unordered_map<uint64_t, std::unique_ptr<DebugRangesSectionWriter>>; - /// Store Rangelists writer for each DWO CU. + /// Store Ranges writer for each DWO CU. LegacyRangesDWOWriers LegacyRangesWritersByCU; std::unordered_map<uint64_t, DIE *> UpdatedDIEsByDWO; >From 98c9edb308018a21183d178271f2af3050e7b96a Mon Sep 17 00:00:00 2001 From: Sayhaan Siddiqui <sayh...@meta.com> Date: Thu, 20 Jun 2024 09:36:36 -0700 Subject: [PATCH 04/15] Formatting changes --- bolt/lib/Rewrite/DWARFRewriter.cpp | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/bolt/lib/Rewrite/DWARFRewriter.cpp b/bolt/lib/Rewrite/DWARFRewriter.cpp index f831e7188da32..2803b5b524750 100644 --- a/bolt/lib/Rewrite/DWARFRewriter.cpp +++ b/bolt/lib/Rewrite/DWARFRewriter.cpp @@ -326,12 +326,11 @@ static cl::opt<bool> KeepARanges( "keep or generate .debug_aranges section if .gdb_index is written"), cl::Hidden, cl::cat(BoltCategory)); -static cl::opt<bool> -DeterministicDebugInfo("deterministic-debuginfo", - cl::desc("disables parallel execution of tasks that may produce " - "nondeterministic debug info"), - cl::init(true), - cl::cat(BoltCategory)); +static cl::opt<bool> DeterministicDebugInfo( + "deterministic-debuginfo", + cl::desc("disables parallel execution of tasks that may produce " + "nondeterministic debug info"), + cl::init(true), cl::cat(BoltCategory)); static cl::opt<std::string> DwarfOutputPath( "dwarf-output-path", @@ -1336,12 +1335,13 @@ void DWARFRewriter::updateDWARFObjectAddressRanges( DIEBldr.addValue(&Die, dwarf::DW_AT_GNU_ranges_base, dwarf::DW_FORM_data4, DIEInteger(INT_MAX)); UpdatedDIEsByDWO[*Unit.getDWOId()] = &Die; - } else if (Unit.getVersion() == 5) + } else if (Unit.getVersion() == 5) { DIEBldr.addValue(&Die, dwarf::DW_AT_rnglists_base, dwarf::DW_FORM_sec_offset, DIEInteger(*RangesBase)); - else + } else { DIEBldr.addValue(&Die, dwarf::DW_AT_rnglists_base, dwarf::DW_FORM_sec_offset, DIEInteger(*RangesBase)); + } return; } >From ac5f042cae43ea49274fec0f5a0b5205e31b9ec1 Mon Sep 17 00:00:00 2001 From: Sayhaan Siddiqui <sayh...@meta.com> Date: Thu, 20 Jun 2024 16:51:53 -0700 Subject: [PATCH 05/15] Updates and formatting changes --- bolt/include/bolt/Core/DebugData.h | 7 ++- bolt/include/bolt/Rewrite/DWARFRewriter.h | 14 +++-- bolt/lib/Core/DebugData.cpp | 7 +-- bolt/lib/Rewrite/DWARFRewriter.cpp | 57 +++++++++++-------- bolt/test/X86/dwarf4-df-dualcu.test | 22 +++---- .../X86/dwarf4-df-input-lowpc-ranges-cus.test | 6 +- .../X86/dwarf4-df-input-lowpc-ranges.test | 2 +- 7 files changed, 64 insertions(+), 51 deletions(-) diff --git a/bolt/include/bolt/Core/DebugData.h b/bolt/include/bolt/Core/DebugData.h index 5c730e63ae0aa..9879f5b9a1f33 100644 --- a/bolt/include/bolt/Core/DebugData.h +++ b/bolt/include/bolt/Core/DebugData.h @@ -197,6 +197,9 @@ class DebugRangesSectionWriter { /// to .debug_ranges uint64_t getEmptyRangesOffset() const { return EmptyRangesOffset; } + /// Returns the RangesBuffer's size. + uint64_t getRangesBufferSize() const { return RangesBuffer->size(); } + /// Returns the SectionOffset. uint64_t getSectionOffset(); @@ -210,8 +213,8 @@ class DebugRangesSectionWriter { static bool classof(const DebugRangesSectionWriter *Writer) { return Writer->getKind() == RangesWriterKind::DebugRangesWriter; } - - void updateRangeBuffer(std::unique_ptr<DebugBufferVector> &CUBuffer); + + void updateRangeBuffer(const DebugBufferVector &CUBuffer); /// Writes out range lists for a current CU being processed. void virtual finalizeSection(){}; diff --git a/bolt/include/bolt/Rewrite/DWARFRewriter.h b/bolt/include/bolt/Rewrite/DWARFRewriter.h index 0c5dd8e6c2f9a..f4754b8be8959 100644 --- a/bolt/include/bolt/Rewrite/DWARFRewriter.h +++ b/bolt/include/bolt/Rewrite/DWARFRewriter.h @@ -89,12 +89,14 @@ class DWARFRewriter { /// Store Rangelists writer for each DWO CU. RangeListsDWOWriers RangeListsWritersByCU; - using LegacyRangesDWOWriers = - std::unordered_map<uint64_t, std::unique_ptr<DebugRangesSectionWriter>>; - /// Store Ranges writer for each DWO CU. - LegacyRangesDWOWriers LegacyRangesWritersByCU; - - std::unordered_map<uint64_t, DIE *> UpdatedDIEsByDWO; + /// Contains ranges writer and die. + struct RangesWriterAndDIE { + std::unique_ptr<DebugRangesSectionWriter> Writer; + DIE *Die; + }; + /// Stores ranges writer and DIE for each DWO CU. + std::unordered_map<uint64_t, RangesWriterAndDIE> + LegacyRangesWritersAndDIEsByCU; std::mutex LocListDebugInfoPatchesMutex; diff --git a/bolt/lib/Core/DebugData.cpp b/bolt/lib/Core/DebugData.cpp index 8895b4923294a..5aa8b7c17f128 100644 --- a/bolt/lib/Core/DebugData.cpp +++ b/bolt/lib/Core/DebugData.cpp @@ -177,10 +177,9 @@ uint64_t DebugRangesSectionWriter::getSectionOffset() { return SectionOffset; } -void DebugRangesSectionWriter::updateRangeBuffer(std::unique_ptr<DebugBufferVector> &CUBuffer) { - for(auto DebugInfo : *CUBuffer){ - RangesBuffer->push_back(DebugInfo); - } +void DebugRangesSectionWriter::updateRangeBuffer( + const DebugBufferVector &CUBuffer) { + *RangesStream << CUBuffer; SectionOffset = RangesBuffer->size(); } diff --git a/bolt/lib/Rewrite/DWARFRewriter.cpp b/bolt/lib/Rewrite/DWARFRewriter.cpp index 2803b5b524750..96b126779b7d0 100644 --- a/bolt/lib/Rewrite/DWARFRewriter.cpp +++ b/bolt/lib/Rewrite/DWARFRewriter.cpp @@ -646,13 +646,13 @@ void DWARFRewriter::updateDebugInfo() { } else { LocListWritersByCU[CUIndex] = std::make_unique<DebugLocWriter>(); if (std::optional<uint64_t> DWOId = CU.getDWOId()) { - assert(LegacyRangesWritersByCU.count(*DWOId) == 0 && + assert(LegacyRangesWritersAndDIEsByCU.count(*DWOId) == 0 && "LegacyRangeLists writer for DWO unit already exists."); auto LegacyRangesSectionWriterByCU = std::make_unique<DebugRangesSectionWriter>(); LegacyRangesSectionWriterByCU->initSection(CU); - LegacyRangesWritersByCU[*DWOId] = - std::move(LegacyRangesSectionWriterByCU); + LegacyRangesWritersAndDIEsByCU[*DWOId] = { + std::move(LegacyRangesSectionWriterByCU), nullptr}; } } return LocListWritersByCU[CUIndex++].get(); @@ -700,7 +700,8 @@ void DWARFRewriter::updateDebugInfo() { if (Unit->getVersion() >= 5) { TempRangesSectionWriter = RangeListsWritersByCU[*DWOId].get(); } else { - TempRangesSectionWriter = LegacyRangesWritersByCU[*DWOId].get(); + TempRangesSectionWriter = + LegacyRangesWritersAndDIEsByCU[*DWOId].Writer.get(); RangesBase = RangesSectionWriter->getSectionOffset(); setDwoRangesBase(*DWOId, *RangesBase); } @@ -1279,14 +1280,13 @@ void DWARFRewriter::updateDWARFObjectAddressRanges( } if (RangesBaseInfo) { - if (RangesBaseInfo.getAttribute() == dwarf::DW_AT_GNU_ranges_base) { - UpdatedDIEsByDWO[*Unit.getDWOId()] = &Die; - } else { + if (RangesBaseInfo.getAttribute() == dwarf::DW_AT_GNU_ranges_base) + LegacyRangesWritersAndDIEsByCU[*Unit.getDWOId()].Die = &Die; + else DIEBldr.replaceValue(&Die, RangesBaseInfo.getAttribute(), RangesBaseInfo.getForm(), DIEInteger(static_cast<uint32_t>(*RangesBase))); - RangesBase = std::nullopt; - } + RangesBase = std::nullopt; } } @@ -1334,7 +1334,7 @@ void DWARFRewriter::updateDWARFObjectAddressRanges( if (Unit.getVersion() <= 4) { DIEBldr.addValue(&Die, dwarf::DW_AT_GNU_ranges_base, dwarf::DW_FORM_data4, DIEInteger(INT_MAX)); - UpdatedDIEsByDWO[*Unit.getDWOId()] = &Die; + LegacyRangesWritersAndDIEsByCU[*Unit.getDWOId()].Die = &Die; } else if (Unit.getVersion() == 5) { DIEBldr.addValue(&Die, dwarf::DW_AT_rnglists_base, dwarf::DW_FORM_sec_offset, DIEInteger(*RangesBase)); @@ -1618,23 +1618,31 @@ void DWARFRewriter::finalizeCompileUnits(DIEBuilder &DIEBlder, DIEStreamer &Streamer, CUOffsetMap &CUMap, const std::list<DWARFUnit *> &CUs) { - size_t BufferSize = 0; for (DWARFUnit *CU : CUs) { if (CU->getVersion() != 4) continue; - std::optional<uint64_t> DWOId; - DWOId = CU->getDWOId(); - if (DWOId) { - if (DIE *Die = UpdatedDIEsByDWO[*DWOId]) { - DIEValue DvalGNUBase = Die->findAttribute(dwarf::DW_AT_GNU_ranges_base); - DIEBlder.replaceValue(Die, dwarf::DW_AT_GNU_ranges_base, - DvalGNUBase.getForm(), DIEInteger(BufferSize)); + if (std::optional<uint64_t> DWOId = CU->getDWOId()) { + auto RangesWriterandDIEIterator = + LegacyRangesWritersAndDIEsByCU.find(*DWOId); + assert(RangesWriterandDIEIterator != + LegacyRangesWritersAndDIEsByCU.end() && + "RangesWriter does not exist for DWOId"); + RangesWriterAndDIE &RangesWriterAndDIE = + RangesWriterandDIEIterator->second; + if (RangesWriterAndDIE.Die) { + DIEValue DvalGNUBase = + RangesWriterAndDIE.Die->findAttribute(dwarf::DW_AT_GNU_ranges_base); + assert(DvalGNUBase && + "GNU_ranges_base attribute does not exist for DWOId"); + DIEBlder.replaceValue( + RangesWriterAndDIE.Die, dwarf::DW_AT_GNU_ranges_base, + DvalGNUBase.getForm(), + DIEInteger(LegacyRangesSectionWriter->getRangesBufferSize())); } - if (LegacyRangesWritersByCU[*DWOId]) { + if (RangesWriterAndDIE.Writer) { std::unique_ptr<DebugBufferVector> RangesWritersContents = - LegacyRangesWritersByCU[*DWOId]->releaseBuffer(); - LegacyRangesSectionWriter->updateRangeBuffer(RangesWritersContents); - BufferSize += RangesWritersContents->size(); + RangesWriterAndDIE.Writer->releaseBuffer(); + LegacyRangesSectionWriter->updateRangeBuffer(*RangesWritersContents); } } } @@ -2333,14 +2341,13 @@ void DWARFRewriter::convertToRangesPatchDebugInfo( } else { DIEBldr.addValue(&Die, RangeBaseAttribute, dwarf::DW_FORM_sec_offset, DIEInteger(INT_MAX)); - UpdatedDIEsByDWO[*Unit.getDWOId()] = &Die; + LegacyRangesWritersAndDIEsByCU[*Unit.getDWOId()].Die = &Die; } } - uint64_t RangeAttrVal = RangesSectionOffset; // HighPC was conveted into DW_AT_ranges. // For DWARF5 we only access ranges through index. DIEBldr.replaceValue(&Die, HighPCAttrInfo.getAttribute(), dwarf::DW_AT_ranges, - RangesForm, DIEInteger(RangeAttrVal)); + RangesForm, DIEInteger(RangesSectionOffset)); } diff --git a/bolt/test/X86/dwarf4-df-dualcu.test b/bolt/test/X86/dwarf4-df-dualcu.test index 87bbe36da645c..fb328eb1872e0 100644 --- a/bolt/test/X86/dwarf4-df-dualcu.test +++ b/bolt/test/X86/dwarf4-df-dualcu.test @@ -37,18 +37,18 @@ ; BOLT: .debug_ranges ; BOLT-NEXT: 00000000 <End of list> -; BOLT-NEXT: 00000010 [[#%.16x,ADDR:]] [[#%.16x,ADDRB:]] -; BOLT-NEXT: 00000010 [[#%.16x,ADDR1:]] [[#%.16x,ADDR1B:]] +; BOLT-NEXT: 00000010 [[#%.16x,ADDR1:]] [[#%.16x,ADDRB1:]] +; BOLT-NEXT: 00000010 [[#%.16x,ADDR2:]] [[#%.16x,ADDRB2:]] ; BOLT-NEXT: 00000010 <End of list> ; BOLT-NEXT: 00000040 <End of list> -; BOLT-NEXT: 00000050 [[#%.16x,ADDR2:]] [[#%.16x,ADDR2B:]] +; BOLT-NEXT: 00000050 [[#%.16x,ADDR1:]] [[#%.16x,ADDRB1:]] ; BOLT-NEXT: 00000050 <End of list> -; BOLT-NEXT: 00000070 [[#%.16x,ADDR3:]] [[#%.16x,ADDR3B:]] +; BOLT-NEXT: 00000070 [[#%.16x,ADDR2:]] [[#%.16x,ADDRB2:]] ; BOLT-NEXT: 00000070 <End of list> -; BOLT-NEXT: 00000090 [[#%.16x,ADDR4:]] [[#%.16x,ADDR4B:]] +; BOLT-NEXT: 00000090 [[#%.16x,ADDR3:]] [[#%.16x,ADDRB3:]] ; BOLT-NEXT: 00000090 <End of list> ; BOLT-NEXT: 000000b0 <End of list> -; BOLT-NEXT: 000000c0 [[#%.16x,ADDR5:]] [[#%.16x,ADDR5B:]] +; BOLT-NEXT: 000000c0 [[#%.16x,ADDR3:]] [[#%.16x,ADDRB3:]] ; BOLT-NEXT: 000000c0 <End of list> ; BOLT: DW_TAG_compile_unit @@ -56,19 +56,19 @@ ; BOLT-NEXT: DW_AT_GNU_dwo_id ; BOLT-NEXT: DW_AT_low_pc [DW_FORM_addr] (0x0000000000000000) ; BOLT-NEXT: DW_AT_ranges [DW_FORM_sec_offset] (0x00000010 -; BOLT-NEXT: [0x[[#ADDR]], 0x[[#ADDRB]]) -; BOLT-NEXT: [0x[[#ADDR1]], 0x[[#ADDR1B]])) +; BOLT-NEXT: [0x[[#ADDR1]], 0x[[#ADDRB1]]) +; BOLT-NEXT: [0x[[#ADDR2]], 0x[[#ADDRB2]])) ; BOLT-NEXT: DW_AT_GNU_addr_base [DW_FORM_sec_offset] (0x00000000) -; BOLT-NEXT: DW_AT_GNU_ranges_base [DW_FORM_sec_offset] (0x00000000) +; BOLT-NEXT: DW_AT_GNU_ranges_base [DW_FORM_sec_offset] (0x00000040) ; BOLT-NEXT: Compile ; BOLT: DW_TAG_compile_unit ; BOLT: DW_AT_GNU_dwo_name [DW_FORM_strp] ( .debug_str[0x00000023] = "helper.dwo.dwo") ; BOLT-NEXT: DW_AT_GNU_dwo_id ; BOLT-NEXT: DW_AT_low_pc [DW_FORM_addr] (0x0000000000000000) ; BOLT-NEXT: DW_AT_ranges [DW_FORM_sec_offset] (0x00000090 -; BOLT-NEXT: [0x[[#ADDR5]], 0x[[#ADDR5B]]) +; BOLT-NEXT: [0x[[#ADDR3]], 0x[[#ADDRB3]]) ; BOLT-NEXT: DW_AT_GNU_addr_base [DW_FORM_sec_offset] (0x00000010) -; BOLT-NEXT: DW_AT_GNU_ranges_base [DW_FORM_sec_offset] (0x00000000) +; BOLT-NEXT: DW_AT_GNU_ranges_base [DW_FORM_sec_offset] (0x000000b0) ; PRE-BOLT-DWO-MAIN: version = 0x0004 ; PRE-BOLT-DWO-MAIN: DW_TAG_compile_unit diff --git a/bolt/test/X86/dwarf4-df-input-lowpc-ranges-cus.test b/bolt/test/X86/dwarf4-df-input-lowpc-ranges-cus.test index 8dae05db12d73..cf9357d5f3c59 100644 --- a/bolt/test/X86/dwarf4-df-input-lowpc-ranges-cus.test +++ b/bolt/test/X86/dwarf4-df-input-lowpc-ranges-cus.test @@ -55,7 +55,7 @@ ; BOLT: DW_TAG_compile_unit ; BOLT: DW_AT_GNU_dwo_name [DW_FORM_strp] ( .debug_str[0x{{[0-9a-fA-F]+}}] = "main.dwo.dwo") ; BOLT-NEXT: DW_AT_GNU_dwo_id -; BOLT-NEXT: DW_AT_GNU_ranges_base [DW_FORM_sec_offset] (0x00000000) +; BOLT-NEXT: DW_AT_GNU_ranges_base [DW_FORM_sec_offset] (0x00000090) ; BOLT-NEXT: DW_AT_low_pc [DW_FORM_addr] (0x0000000000000000) ; BOLT-NEXT: DW_AT_ranges [DW_FORM_sec_offset] (0x00000010 ; BOLT-NEXT: [0x[[#ADDR1]], 0x[[#ADDRB1]]) @@ -66,11 +66,12 @@ ; BOLT-NEXT: [0x[[#ADDR6]], 0x[[#ADDRB6]]) ; BOLT-NEXT: [0x[[#ADDR7]], 0x[[#ADDRB7]]) ; BOLT-NEXT: DW_AT_GNU_addr_base [DW_FORM_sec_offset] (0x00000000) +; BOLT-NEXT: Compile Unit ; BOLT: DW_TAG_compile_unit ; BOLT: DW_AT_GNU_dwo_name [DW_FORM_strp] ( .debug_str[0x{{[0-9a-fA-F]+}}] = "mainOther.dwo.dwo") ; BOLT-NEXT: DW_AT_GNU_dwo_id -; BOLT-NEXT: DW_AT_GNU_ranges_base [DW_FORM_sec_offset] (0x00000000) +; BOLT-NEXT: DW_AT_GNU_ranges_base [DW_FORM_sec_offset] (0x000001a0) ; BOLT-NEXT: DW_AT_low_pc [DW_FORM_addr] (0x0000000000000000) ; BOLT-NEXT: DW_AT_ranges [DW_FORM_sec_offset] (0x00000120 ; BOLT-NEXT: [0x[[#ADDR8]], 0x[[#ADDRB8]]) @@ -81,6 +82,7 @@ ; BOLT-NEXT: [0x[[#ADDR13]], 0x[[#ADDRB13]]) ; BOLT-NEXT: [0x[[#ADDR14]], 0x[[#ADDRB14]]) ; BOLT-NEXT: DW_AT_GNU_addr_base [DW_FORM_sec_offset] (0x00000018) +; BOLT: {{^$}} ; BOLT-DWO-MAIN: DW_TAG_subprogram ; BOLT-DWO-MAIN-NEXT: DW_AT_ranges [DW_FORM_sec_offset] (0x00000010 diff --git a/bolt/test/X86/dwarf4-df-input-lowpc-ranges.test b/bolt/test/X86/dwarf4-df-input-lowpc-ranges.test index 908ef429b83ab..ab4353a282475 100644 --- a/bolt/test/X86/dwarf4-df-input-lowpc-ranges.test +++ b/bolt/test/X86/dwarf4-df-input-lowpc-ranges.test @@ -36,7 +36,7 @@ ; BOLT: DW_TAG_compile_unit ; BOLT: DW_AT_GNU_dwo_name [DW_FORM_strp] ( .debug_str[0x{{[0-9a-fA-F]+}}] = "main.dwo.dwo") ; BOLT-NEXT: DW_AT_GNU_dwo_id -; BOLT-NEXT: DW_AT_GNU_ranges_base [DW_FORM_sec_offset] (0x00000000) +; BOLT-NEXT: DW_AT_GNU_ranges_base [DW_FORM_sec_offset] (0x00000090) ; BOLT-NEXT: DW_AT_low_pc [DW_FORM_addr] (0x0000000000000000) ; BOLT-NEXT: DW_AT_ranges [DW_FORM_sec_offset] (0x00000010 ; BOLT-NEXT: [0x[[#ADDR1]], 0x[[#ADDRB1]]) >From 9506749e473e2380e418d5edb545292c8466132d Mon Sep 17 00:00:00 2001 From: Sayhaan Siddiqui <sayh...@meta.com> Date: Thu, 20 Jun 2024 16:56:06 -0700 Subject: [PATCH 06/15] Formatting changes --- bolt/include/bolt/Core/DebugData.h | 2 +- bolt/lib/Core/DebugData.cpp | 2 +- bolt/lib/Rewrite/DWARFRewriter.cpp | 5 +++-- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/bolt/include/bolt/Core/DebugData.h b/bolt/include/bolt/Core/DebugData.h index 9879f5b9a1f33..905185c6c913b 100644 --- a/bolt/include/bolt/Core/DebugData.h +++ b/bolt/include/bolt/Core/DebugData.h @@ -214,7 +214,7 @@ class DebugRangesSectionWriter { return Writer->getKind() == RangesWriterKind::DebugRangesWriter; } - void updateRangeBuffer(const DebugBufferVector &CUBuffer); + void appendToRangeBuffer(const DebugBufferVector &CUBuffer); /// Writes out range lists for a current CU being processed. void virtual finalizeSection(){}; diff --git a/bolt/lib/Core/DebugData.cpp b/bolt/lib/Core/DebugData.cpp index 5aa8b7c17f128..08d4c45aac791 100644 --- a/bolt/lib/Core/DebugData.cpp +++ b/bolt/lib/Core/DebugData.cpp @@ -177,7 +177,7 @@ uint64_t DebugRangesSectionWriter::getSectionOffset() { return SectionOffset; } -void DebugRangesSectionWriter::updateRangeBuffer( +void DebugRangesSectionWriter::appendToRangeBuffer( const DebugBufferVector &CUBuffer) { *RangesStream << CUBuffer; SectionOffset = RangesBuffer->size(); diff --git a/bolt/lib/Rewrite/DWARFRewriter.cpp b/bolt/lib/Rewrite/DWARFRewriter.cpp index 96b126779b7d0..94744fc348673 100644 --- a/bolt/lib/Rewrite/DWARFRewriter.cpp +++ b/bolt/lib/Rewrite/DWARFRewriter.cpp @@ -330,7 +330,8 @@ static cl::opt<bool> DeterministicDebugInfo( "deterministic-debuginfo", cl::desc("disables parallel execution of tasks that may produce " "nondeterministic debug info"), - cl::init(true), cl::cat(BoltCategory)); + cl::init(true), + cl::cat(BoltCategory)); static cl::opt<std::string> DwarfOutputPath( "dwarf-output-path", @@ -1642,7 +1643,7 @@ void DWARFRewriter::finalizeCompileUnits(DIEBuilder &DIEBlder, if (RangesWriterAndDIE.Writer) { std::unique_ptr<DebugBufferVector> RangesWritersContents = RangesWriterAndDIE.Writer->releaseBuffer(); - LegacyRangesSectionWriter->updateRangeBuffer(*RangesWritersContents); + LegacyRangesSectionWriter->appendToRangeBuffer(*RangesWritersContents); } } } >From 55a9b284a68c22e43de063d60d38c8993d37669f Mon Sep 17 00:00:00 2001 From: Sayhaan Siddiqui <sayh...@meta.com> Date: Thu, 20 Jun 2024 16:58:03 -0700 Subject: [PATCH 07/15] Formatting changes --- bolt/lib/Rewrite/DWARFRewriter.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/bolt/lib/Rewrite/DWARFRewriter.cpp b/bolt/lib/Rewrite/DWARFRewriter.cpp index 94744fc348673..e58282ccb8ac1 100644 --- a/bolt/lib/Rewrite/DWARFRewriter.cpp +++ b/bolt/lib/Rewrite/DWARFRewriter.cpp @@ -330,8 +330,7 @@ static cl::opt<bool> DeterministicDebugInfo( "deterministic-debuginfo", cl::desc("disables parallel execution of tasks that may produce " "nondeterministic debug info"), - cl::init(true), - cl::cat(BoltCategory)); + cl::init(true), cl::cat(BoltCategory)); static cl::opt<std::string> DwarfOutputPath( "dwarf-output-path", >From e002be1168e50b3a44dadc42748ca95a0783da4e Mon Sep 17 00:00:00 2001 From: Sayhaan Siddiqui <sayh...@meta.com> Date: Thu, 20 Jun 2024 16:58:45 -0700 Subject: [PATCH 08/15] Formatting changes --- bolt/lib/Rewrite/DWARFRewriter.cpp | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/bolt/lib/Rewrite/DWARFRewriter.cpp b/bolt/lib/Rewrite/DWARFRewriter.cpp index e58282ccb8ac1..02e5d1b356072 100644 --- a/bolt/lib/Rewrite/DWARFRewriter.cpp +++ b/bolt/lib/Rewrite/DWARFRewriter.cpp @@ -326,11 +326,12 @@ static cl::opt<bool> KeepARanges( "keep or generate .debug_aranges section if .gdb_index is written"), cl::Hidden, cl::cat(BoltCategory)); -static cl::opt<bool> DeterministicDebugInfo( - "deterministic-debuginfo", - cl::desc("disables parallel execution of tasks that may produce " - "nondeterministic debug info"), - cl::init(true), cl::cat(BoltCategory)); +static cl::opt<bool> +DeterministicDebugInfo("deterministic-debuginfo", + cl::desc("disables parallel execution of tasks that may produce " + "nondeterministic debug info"), + cl::init(true), + cl::cat(BoltCategory)); static cl::opt<std::string> DwarfOutputPath( "dwarf-output-path", >From 288fc12bd0963ef5b3362ce6e15000cf5fa5d199 Mon Sep 17 00:00:00 2001 From: Sayhaan Siddiqui <sayh...@meta.com> Date: Thu, 20 Jun 2024 16:59:45 -0700 Subject: [PATCH 09/15] Formatting changes --- bolt/lib/Rewrite/DWARFRewriter.cpp | 6 ------ 1 file changed, 6 deletions(-) diff --git a/bolt/lib/Rewrite/DWARFRewriter.cpp b/bolt/lib/Rewrite/DWARFRewriter.cpp index 02e5d1b356072..4ba61a4fe91cb 100644 --- a/bolt/lib/Rewrite/DWARFRewriter.cpp +++ b/bolt/lib/Rewrite/DWARFRewriter.cpp @@ -1304,12 +1304,6 @@ void DWARFRewriter::updateDWARFObjectAddressRanges( RangesAttrInfo.getForm() == dwarf::DW_FORM_sec_offset) NeedConverted = true; - if (Unit.isDWOUnit()) { - std::optional<uint64_t> DWOId = Unit.getDWOId(); - if (!DWOId) - errs() << "BOLT-WARNING: [internal-dwarf-error]: DWOId is not found " - "for DWO Unit."; - } if (NeedConverted || RangesAttrInfo.getForm() == dwarf::DW_FORM_rnglistx) DIEBldr.replaceValue(&Die, dwarf::DW_AT_ranges, dwarf::DW_FORM_rnglistx, DIEInteger(DebugRangesOffset)); >From a9b9fe42bd7e3a5affbccedbb0538275d4f3c53b Mon Sep 17 00:00:00 2001 From: Sayhaan Siddiqui <sayh...@meta.com> Date: Fri, 21 Jun 2024 09:35:39 -0700 Subject: [PATCH 10/15] Updates and formatting changes --- bolt/include/bolt/Core/DebugData.h | 3 --- bolt/lib/Rewrite/DWARFRewriter.cpp | 10 ++++------ 2 files changed, 4 insertions(+), 9 deletions(-) diff --git a/bolt/include/bolt/Core/DebugData.h b/bolt/include/bolt/Core/DebugData.h index 905185c6c913b..7364cea9c0840 100644 --- a/bolt/include/bolt/Core/DebugData.h +++ b/bolt/include/bolt/Core/DebugData.h @@ -197,9 +197,6 @@ class DebugRangesSectionWriter { /// to .debug_ranges uint64_t getEmptyRangesOffset() const { return EmptyRangesOffset; } - /// Returns the RangesBuffer's size. - uint64_t getRangesBufferSize() const { return RangesBuffer->size(); } - /// Returns the SectionOffset. uint64_t getSectionOffset(); diff --git a/bolt/lib/Rewrite/DWARFRewriter.cpp b/bolt/lib/Rewrite/DWARFRewriter.cpp index 4ba61a4fe91cb..701e6c94ee586 100644 --- a/bolt/lib/Rewrite/DWARFRewriter.cpp +++ b/bolt/lib/Rewrite/DWARFRewriter.cpp @@ -1632,13 +1632,11 @@ void DWARFRewriter::finalizeCompileUnits(DIEBuilder &DIEBlder, DIEBlder.replaceValue( RangesWriterAndDIE.Die, dwarf::DW_AT_GNU_ranges_base, DvalGNUBase.getForm(), - DIEInteger(LegacyRangesSectionWriter->getRangesBufferSize())); - } - if (RangesWriterAndDIE.Writer) { - std::unique_ptr<DebugBufferVector> RangesWritersContents = - RangesWriterAndDIE.Writer->releaseBuffer(); - LegacyRangesSectionWriter->appendToRangeBuffer(*RangesWritersContents); + DIEInteger(LegacyRangesSectionWriter->getSectionOffset())); } + std::unique_ptr<DebugBufferVector> RangesWritersContents = + RangesWriterAndDIE.Writer->releaseBuffer(); + LegacyRangesSectionWriter->appendToRangeBuffer(*RangesWritersContents); } } DIEBlder.generateAbbrevs(); >From 82388c7186757676e31896f4f8b0b0cae70a629b Mon Sep 17 00:00:00 2001 From: Amir Ayupov <aau...@meta.com> Date: Tue, 1 Jun 2021 11:37:41 -0700 Subject: [PATCH 11/15] Rebase: [Facebook] Add clang driver options to test debug info and BOLT Summary: This is an essential piece of infrastructure for us to be continuously testing debug info with BOLT. We can't only make changes to a test repo because we need to change debuginfo tests to call BOLT, hence, this diff needs to sit in our opensource repo. But when upstreaming to LLVM, this should be kept BOLT-only outside of LLVM. When upstreaming, we need to git diff and check all folders that are being modified by our commits and discard this one (and leave as an internal diff). To test BOLT in debuginfo tests, configure it with -DLLVM_TEST_BOLT=ON. Then run check-lldb and check-debuginfo. Manual rebase conflict history: https://phabricator.intern.facebook.com/D29205224 https://phabricator.intern.facebook.com/D29564078 https://phabricator.intern.facebook.com/D33289118 https://phabricator.intern.facebook.com/D34957174 https://phabricator.intern.facebook.com/D35317341 Test Plan: tested locally Configured with: -DLLVM_ENABLE_PROJECTS="clang;lld;lldb;compiler-rt;bolt;debuginfo-tests" -DLLVM_TEST_BOLT=ON Ran test suite with: ninja check-debuginfo ninja check-lldb Reviewers: maks, #llvm-bolt Reviewed By: maks Subscribers: ayermolo, phabricatorlinter Differential Revision: https://phabricator.intern.facebook.com/D46256657 Tasks: T92898286 --- clang/include/clang/Driver/Options.td | 4 ++++ clang/lib/Driver/ToolChains/Gnu.cpp | 29 ++++++++++++++++++++++++++ cross-project-tests/lit.cfg.py | 14 ++++++++++++- cross-project-tests/lit.site.cfg.py.in | 4 ++++ lldb/test/API/lit.cfg.py | 5 +++++ lldb/test/API/lit.site.cfg.py.in | 8 +++++++ lldb/test/Shell/helper/toolchain.py | 5 +++++ lldb/test/Shell/lit.site.cfg.py.in | 9 ++++++++ llvm/CMakeLists.txt | 4 ++++ 9 files changed, 81 insertions(+), 1 deletion(-) diff --git a/clang/include/clang/Driver/Options.td b/clang/include/clang/Driver/Options.td index d44faa55c456f..63bb86717bb14 100644 --- a/clang/include/clang/Driver/Options.td +++ b/clang/include/clang/Driver/Options.td @@ -5483,6 +5483,10 @@ def pg : Flag<["-"], "pg">, HelpText<"Enable mcount instrumentation">, MarshallingInfoFlag<CodeGenOpts<"InstrumentForProfiling">>; def pipe : Flag<["-", "--"], "pipe">, HelpText<"Use pipes between commands, when possible">; +// Facebook T92898286 +def post_link_optimize : Flag<["--"], "post-link-optimize">, + HelpText<"Apply post-link optimizations using BOLT">; +// End Facebook T92898286 def prebind__all__twolevel__modules : Flag<["-"], "prebind_all_twolevel_modules">; def prebind : Flag<["-"], "prebind">; def preload : Flag<["-"], "preload">; diff --git a/clang/lib/Driver/ToolChains/Gnu.cpp b/clang/lib/Driver/ToolChains/Gnu.cpp index b141e5f2adfab..f7611af5763ab 100644 --- a/clang/lib/Driver/ToolChains/Gnu.cpp +++ b/clang/lib/Driver/ToolChains/Gnu.cpp @@ -672,12 +672,41 @@ void tools::gnutools::Linker::ConstructJob(Compilation &C, const JobAction &JA, } } + // Facebook T92898286 + if (Args.hasArg(options::OPT_post_link_optimize)) + CmdArgs.push_back("-q"); + // End Facebook T92898286 + Args.AddAllArgs(CmdArgs, options::OPT_T); const char *Exec = Args.MakeArgString(ToolChain.GetLinkerPath()); C.addCommand(std::make_unique<Command>(JA, *this, ResponseFileSupport::AtFileCurCP(), Exec, CmdArgs, Inputs, Output)); + // Facebook T92898286 + if (!Args.hasArg(options::OPT_post_link_optimize) || !Output.isFilename()) + return; + + const char *MvExec = Args.MakeArgString(ToolChain.GetProgramPath("mv")); + ArgStringList MoveCmdArgs; + MoveCmdArgs.push_back(Output.getFilename()); + const char *PreBoltBin = + Args.MakeArgString(Twine(Output.getFilename()) + ".pre-bolt"); + MoveCmdArgs.push_back(PreBoltBin); + C.addCommand(std::make_unique<Command>(JA, *this, ResponseFileSupport::None(), + MvExec, MoveCmdArgs, std::nullopt)); + + ArgStringList BoltCmdArgs; + const char *BoltExec = + Args.MakeArgString(ToolChain.GetProgramPath("llvm-bolt")); + BoltCmdArgs.push_back(PreBoltBin); + BoltCmdArgs.push_back("-reorder-blocks=reverse"); + BoltCmdArgs.push_back("-update-debug-sections"); + BoltCmdArgs.push_back("-o"); + BoltCmdArgs.push_back(Output.getFilename()); + C.addCommand(std::make_unique<Command>(JA, *this, ResponseFileSupport::None(), + BoltExec, BoltCmdArgs, std::nullopt)); + // End Facebook T92898286 } void tools::gnutools::Assembler::ConstructJob(Compilation &C, diff --git a/cross-project-tests/lit.cfg.py b/cross-project-tests/lit.cfg.py index 774c4eaf4d976..619634578dfe6 100644 --- a/cross-project-tests/lit.cfg.py +++ b/cross-project-tests/lit.cfg.py @@ -84,7 +84,13 @@ def get_required_attr(config, attr_name): # use_clang() and use_lld() respectively, so set them to "", if needed. if not hasattr(config, "clang_src_dir"): config.clang_src_dir = "" -llvm_config.use_clang(required=("clang" in config.llvm_enabled_projects)) +# Facebook T92898286 +should_test_bolt = get_required_attr(config, "llvm_test_bolt") +if should_test_bolt: + llvm_config.use_clang(required=("clang" in config.llvm_enabled_projects), additional_flags=["--post-link-optimize"]) +else: + llvm_config.use_clang(required=("clang" in config.llvm_enabled_projects)) +# End Facebook T92898286 if not hasattr(config, "lld_src_dir"): config.lld_src_dir = "" @@ -293,3 +299,9 @@ def get_clang_default_dwarf_version_string(triple): # Allow 'REQUIRES: XXX-registered-target' in tests. for arch in config.targets_to_build: config.available_features.add(arch.lower() + "-registered-target") + +# Facebook T92898286 +# Ensure the user's PYTHONPATH is included. +if "PYTHONPATH" in os.environ: + config.environment["PYTHONPATH"] = os.environ["PYTHONPATH"] +# End Facebook T92898286 diff --git a/cross-project-tests/lit.site.cfg.py.in b/cross-project-tests/lit.site.cfg.py.in index 39458dfc79afd..2d53cd377f033 100644 --- a/cross-project-tests/lit.site.cfg.py.in +++ b/cross-project-tests/lit.site.cfg.py.in @@ -21,6 +21,10 @@ config.mlir_src_root = "@MLIR_SOURCE_DIR@" config.llvm_use_sanitizer = "@LLVM_USE_SANITIZER@" +# Facebook T92898286 +config.llvm_test_bolt = lit.util.pythonize_bool("@LLVM_TEST_BOLT@") +# End Facebook T92898286 + import lit.llvm lit.llvm.initialize(lit_config, config) diff --git a/lldb/test/API/lit.cfg.py b/lldb/test/API/lit.cfg.py index d934349fe3ca3..d4a62c51458cc 100644 --- a/lldb/test/API/lit.cfg.py +++ b/lldb/test/API/lit.cfg.py @@ -248,6 +248,11 @@ def delete_module_cache(path): if is_configured("lldb_framework_dir"): dotest_cmd += ["--framework", config.lldb_framework_dir] +# Facebook T92898286 +if is_configured("llvm_test_bolt"): + dotest_cmd += ["-E", '"--post-link-optimize"'] +# End Facebook T92898286 + if ( "lldb-repro-capture" in config.available_features or "lldb-repro-replay" in config.available_features diff --git a/lldb/test/API/lit.site.cfg.py.in b/lldb/test/API/lit.site.cfg.py.in index 8b2d09ae41cd2..602f45759e48f 100644 --- a/lldb/test/API/lit.site.cfg.py.in +++ b/lldb/test/API/lit.site.cfg.py.in @@ -1,5 +1,9 @@ @LIT_SITE_CFG_IN_HEADER@ +#Facebook T92898286 +import lit.util +#End Facebook T92898286 + config.llvm_src_root = "@LLVM_SOURCE_DIR@" config.llvm_obj_root = "@LLVM_BINARY_DIR@" config.llvm_tools_dir = lit_config.substitute("@LLVM_TOOLS_DIR@") @@ -39,6 +43,10 @@ config.libcxx_include_target_dir = "@LIBCXX_GENERATED_INCLUDE_TARGET_DIR@" config.lldb_module_cache = os.path.join("@LLDB_TEST_MODULE_CACHE_LLDB@", "lldb-api") config.clang_module_cache = os.path.join("@LLDB_TEST_MODULE_CACHE_CLANG@", "lldb-api") +# Facebook T92898286 +config.llvm_test_bolt = lit.util.pythonize_bool("@LLVM_TEST_BOLT@") +# End Facebook T92898286 + # Plugins lldb_build_intel_pt = '@LLDB_BUILD_INTEL_PT@' if lldb_build_intel_pt == '1': diff --git a/lldb/test/Shell/helper/toolchain.py b/lldb/test/Shell/helper/toolchain.py index 255955fc70d8c..7b7be06643166 100644 --- a/lldb/test/Shell/helper/toolchain.py +++ b/lldb/test/Shell/helper/toolchain.py @@ -165,6 +165,11 @@ def use_support_substitutions(config): if config.cmake_sysroot: host_flags += ["--sysroot={}".format(config.cmake_sysroot)] + # Facebook T92898286 + if config.llvm_test_bolt: + host_flags += ["--post-link-optimize"] + # End Facebook T92898286 + host_flags = " ".join(host_flags) config.substitutions.append(("%clang_host", "%clang " + host_flags)) config.substitutions.append(("%clangxx_host", "%clangxx " + host_flags)) diff --git a/lldb/test/Shell/lit.site.cfg.py.in b/lldb/test/Shell/lit.site.cfg.py.in index b69e7bce1bc0b..fe8323734b7db 100644 --- a/lldb/test/Shell/lit.site.cfg.py.in +++ b/lldb/test/Shell/lit.site.cfg.py.in @@ -1,5 +1,10 @@ @LIT_SITE_CFG_IN_HEADER@ +#Facebook T92898286 +import lit.util +#End Facebook T92898286 + + config.llvm_src_root = "@LLVM_SOURCE_DIR@" config.llvm_obj_root = "@LLVM_BINARY_DIR@" config.llvm_tools_dir = lit_config.substitute("@LLVM_TOOLS_DIR@") @@ -31,6 +36,10 @@ config.llvm_use_sanitizer = "@LLVM_USE_SANITIZER@" config.lldb_module_cache = os.path.join("@LLDB_TEST_MODULE_CACHE_LLDB@", "lldb-shell") config.clang_module_cache = os.path.join("@LLDB_TEST_MODULE_CACHE_CLANG@", "lldb-shell") +# Facebook T92898286 +config.llvm_test_bolt = lit.util.pythonize_bool("@LLVM_TEST_BOLT@") +# End Facebook T92898286 + import lit.llvm lit.llvm.initialize(lit_config, config) diff --git a/llvm/CMakeLists.txt b/llvm/CMakeLists.txt index 3208147101c0d..ecd36d2564e4f 100644 --- a/llvm/CMakeLists.txt +++ b/llvm/CMakeLists.txt @@ -709,6 +709,10 @@ set(LLVM_LIB_FUZZING_ENGINE "" CACHE PATH option(LLVM_USE_SPLIT_DWARF "Use -gsplit-dwarf when compiling llvm and --gdb-index when linking." OFF) +# Facebook T92898286 +option(LLVM_TEST_BOLT "Enable BOLT testing in non-BOLT tests that use clang" OFF) +# End Facebook T92898286 + # Define an option controlling whether we should build for 32-bit on 64-bit # platforms, where supported. if( CMAKE_SIZEOF_VOID_P EQUAL 8 AND NOT (WIN32 OR ${CMAKE_SYSTEM_NAME} MATCHES "AIX")) >From e048af8e9243cdcbdbeac3dc2ff8fe26607a7f2b Mon Sep 17 00:00:00 2001 From: Rafael Auler <rafaelau...@fb.com> Date: Thu, 5 Aug 2021 14:17:07 -0700 Subject: [PATCH 12/15] Rebase: [Facebook] [MC] Introduce NeverAlign fragment type Summary: Introduce NeverAlign fragment type. The intended usage of this fragment is to insert it before a pair of macro-op fusion eligible instructions. NeverAlign fragment ensures that the next fragment (first instruction in the pair) does not end at a given alignment boundary by emitting a minimal size nop if necessary. In effect, it ensures that a pair of macro-fusible instructions is not split by a given alignment boundary, which is a precondition for macro-op fusion in modern Intel Cores (64B = cache line size, see Intel Architecture Optimization Reference Manual, 2.3.2.1 Legacy Decode Pipeline: Macro-Fusion). This patch introduces functionality used by BOLT when emitting code with MacroFusion alignment already in place. The use case is different from BoundaryAlign and instruction bundling: - BoundaryAlign can be extended to perform the desired alignment for the first instruction in the macro-op fusion pair (D101817). However, this approach has higher overhead due to reliance on relaxation as BoundaryAlign requires in the general case - see https://reviews.llvm.org/D97982#2710638. - Instruction bundling: the intent of NeverAlign fragment is to prevent the first instruction in a pair ending at a given alignment boundary, by inserting at most one minimum size nop. It's OK if either instruction crosses the cache line. Padding both instructions using bundles to not cross the alignment boundary would result in excessive padding. There's no straightforward way to request instruction bundling to avoid a given end alignment for the first instruction in the bundle. LLVM: https://reviews.llvm.org/D97982 Manual rebase conflict history: https://phabricator.intern.facebook.com/D30142613 Test Plan: sandcastle Reviewers: #llvm-bolt Subscribers: phabricatorlinter Differential Revision: https://phabricator.intern.facebook.com/D31361547 --- bolt/lib/Core/BinaryEmitter.cpp | 1 + llvm/include/llvm/MC/MCFragment.h | 22 ++ llvm/include/llvm/MC/MCObjectStreamer.h | 2 + llvm/include/llvm/MC/MCStreamer.h | 6 + llvm/lib/MC/MCAssembler.cpp | 118 ++++++---- llvm/lib/MC/MCFragment.cpp | 12 + llvm/lib/MC/MCObjectStreamer.cpp | 5 + llvm/lib/MC/MCStreamer.cpp | 2 + .../lib/Target/X86/AsmParser/X86AsmParser.cpp | 24 ++ llvm/test/MC/X86/directive-avoid_end_align.s | 208 ++++++++++++++++++ 10 files changed, 363 insertions(+), 37 deletions(-) create mode 100644 llvm/test/MC/X86/directive-avoid_end_align.s diff --git a/bolt/lib/Core/BinaryEmitter.cpp b/bolt/lib/Core/BinaryEmitter.cpp index 5793963f9b80d..c231fffa0d5ff 100644 --- a/bolt/lib/Core/BinaryEmitter.cpp +++ b/bolt/lib/Core/BinaryEmitter.cpp @@ -487,6 +487,7 @@ void BinaryEmitter::emitFunctionBody(BinaryFunction &BF, FunctionFragment &FF, // This assumes the second instruction in the macro-op pair will get // assigned to its own MCRelaxableFragment. Since all JCC instructions // are relaxable, we should be safe. + Streamer.emitNeverAlignCodeAtEnd(/*Alignment to avoid=*/64, *BC.STI); } if (!EmitCodeOnly) { diff --git a/llvm/include/llvm/MC/MCFragment.h b/llvm/include/llvm/MC/MCFragment.h index a9b19dc56f16a..256d98423e030 100644 --- a/llvm/include/llvm/MC/MCFragment.h +++ b/llvm/include/llvm/MC/MCFragment.h @@ -33,6 +33,7 @@ class MCFragment : public ilist_node_with_parent<MCFragment, MCSection> { public: enum FragmentType : uint8_t { FT_Align, + FT_NeverAlign, FT_Data, FT_CompactEncodedInst, FT_Fill, @@ -344,6 +345,27 @@ class MCAlignFragment : public MCFragment { } }; +class MCNeverAlignFragment : public MCFragment { + /// The alignment the end of the next fragment should avoid. + unsigned Alignment; + + /// When emitting Nops some subtargets have specific nop encodings. + const MCSubtargetInfo &STI; + +public: + MCNeverAlignFragment(unsigned Alignment, const MCSubtargetInfo &STI, + MCSection *Sec = nullptr) + : MCFragment(FT_NeverAlign, false, Sec), Alignment(Alignment), STI(STI) {} + + unsigned getAlignment() const { return Alignment; } + + const MCSubtargetInfo &getSubtargetInfo() const { return STI; } + + static bool classof(const MCFragment *F) { + return F->getKind() == MCFragment::FT_NeverAlign; + } +}; + class MCFillFragment : public MCFragment { uint8_t ValueSize; /// Value to use for filling bytes. diff --git a/llvm/include/llvm/MC/MCObjectStreamer.h b/llvm/include/llvm/MC/MCObjectStreamer.h index e212d54613980..c7d760721e369 100644 --- a/llvm/include/llvm/MC/MCObjectStreamer.h +++ b/llvm/include/llvm/MC/MCObjectStreamer.h @@ -157,6 +157,8 @@ class MCObjectStreamer : public MCStreamer { unsigned MaxBytesToEmit = 0) override; void emitCodeAlignment(Align ByteAlignment, const MCSubtargetInfo *STI, unsigned MaxBytesToEmit = 0) override; + void emitNeverAlignCodeAtEnd(unsigned ByteAlignment, + const MCSubtargetInfo &STI) override; void emitValueToOffset(const MCExpr *Offset, unsigned char Value, SMLoc Loc) override; void emitDwarfLocDirective(unsigned FileNo, unsigned Line, unsigned Column, diff --git a/llvm/include/llvm/MC/MCStreamer.h b/llvm/include/llvm/MC/MCStreamer.h index b7468cf70a664..dd813192d9ca0 100644 --- a/llvm/include/llvm/MC/MCStreamer.h +++ b/llvm/include/llvm/MC/MCStreamer.h @@ -887,6 +887,12 @@ class MCStreamer { virtual void emitCodeAlignment(Align Alignment, const MCSubtargetInfo *STI, unsigned MaxBytesToEmit = 0); + /// If the end of the fragment following this NeverAlign fragment ever gets + /// aligned to \p ByteAlignment, this fragment emits a single nop before the + /// following fragment to break this end-alignment. + virtual void emitNeverAlignCodeAtEnd(unsigned ByteAlignment, + const MCSubtargetInfo &STI); + /// Emit some number of copies of \p Value until the byte offset \p /// Offset is reached. /// diff --git a/llvm/lib/MC/MCAssembler.cpp b/llvm/lib/MC/MCAssembler.cpp index ad30b5ce9e631..62baeb93ea7d0 100644 --- a/llvm/lib/MC/MCAssembler.cpp +++ b/llvm/lib/MC/MCAssembler.cpp @@ -298,6 +298,43 @@ bool MCAssembler::evaluateFixup(const MCAsmLayout &Layout, const MCFixup &Fixup, return IsResolved; } +/// Check if the branch crosses the boundary. +/// +/// \param StartAddr start address of the fused/unfused branch. +/// \param Size size of the fused/unfused branch. +/// \param BoundaryAlignment alignment requirement of the branch. +/// \returns true if the branch cross the boundary. +static bool mayCrossBoundary(uint64_t StartAddr, uint64_t Size, + Align BoundaryAlignment) { + uint64_t EndAddr = StartAddr + Size; + return (StartAddr >> Log2(BoundaryAlignment)) != + ((EndAddr - 1) >> Log2(BoundaryAlignment)); +} + +/// Check if the branch is against the boundary. +/// +/// \param StartAddr start address of the fused/unfused branch. +/// \param Size size of the fused/unfused branch. +/// \param BoundaryAlignment alignment requirement of the branch. +/// \returns true if the branch is against the boundary. +static bool isAgainstBoundary(uint64_t StartAddr, uint64_t Size, + Align BoundaryAlignment) { + uint64_t EndAddr = StartAddr + Size; + return (EndAddr & (BoundaryAlignment.value() - 1)) == 0; +} + +/// Check if the branch needs padding. +/// +/// \param StartAddr start address of the fused/unfused branch. +/// \param Size size of the fused/unfused branch. +/// \param BoundaryAlignment alignment requirement of the branch. +/// \returns true if the branch needs padding. +static bool needPadding(uint64_t StartAddr, uint64_t Size, + Align BoundaryAlignment) { + return mayCrossBoundary(StartAddr, Size, BoundaryAlignment) || + isAgainstBoundary(StartAddr, Size, BoundaryAlignment); +} + uint64_t MCAssembler::computeFragmentSize(const MCAsmLayout &Layout, const MCFragment &F) const { assert(getBackendPtr() && "Requires assembler backend"); @@ -358,6 +395,41 @@ uint64_t MCAssembler::computeFragmentSize(const MCAsmLayout &Layout, return Size; } + case MCFragment::FT_NeverAlign: { + // Disclaimer: NeverAlign fragment size depends on the size of its immediate + // successor, but NeverAlign need not be a MCRelaxableFragment. + // NeverAlign fragment size is recomputed if the successor is relaxed: + // - If RelaxableFragment is relaxed, it gets invalidated by marking its + // predecessor as LastValidFragment. + // - This forces the assembler to call MCAsmLayout::layoutFragment on that + // relaxable fragment, which in turn will always ask the predecessor to + // compute its size (see "computeFragmentSize(prev)" in layoutFragment). + // + // In short, the simplest way to ensure that computeFragmentSize() is sane + // is to establish the following rule: it should never examine fragments + // after the current fragment in the section. If we logically need to + // examine any fragment after the current fragment, we need to do that using + // relaxation, inside MCAssembler::layoutSectionOnce. + const MCNeverAlignFragment &NAF = cast<MCNeverAlignFragment>(F); + const MCFragment *NF = F.getNextNode(); + uint64_t Offset = Layout.getFragmentOffset(&NAF); + size_t NextFragSize = 0; + if (const auto *NextFrag = dyn_cast<MCRelaxableFragment>(NF)) { + NextFragSize = NextFrag->getContents().size(); + } else if (const auto *NextFrag = dyn_cast<MCDataFragment>(NF)) { + NextFragSize = NextFrag->getContents().size(); + } else { + llvm_unreachable("Didn't find the expected fragment after NeverAlign"); + } + // Check if the next fragment ends at the alignment we want to avoid. + if (isAgainstBoundary(Offset, NextFragSize, Align(NAF.getAlignment()))) { + // Avoid this alignment by introducing minimum nop. + assert(getBackend().getMinimumNopSize() != NAF.getAlignment()); + return getBackend().getMinimumNopSize(); + } + return 0; + } + case MCFragment::FT_Org: { const MCOrgFragment &OF = cast<MCOrgFragment>(F); MCValue Value; @@ -581,6 +653,15 @@ static void writeFragment(raw_ostream &OS, const MCAssembler &Asm, break; } + case MCFragment::FT_NeverAlign: { + const MCNeverAlignFragment &NAF = cast<MCNeverAlignFragment>(F); + if (!Asm.getBackend().writeNopData(OS, FragmentSize, + &NAF.getSubtargetInfo())) + report_fatal_error("unable to write nop sequence of " + + Twine(FragmentSize) + " bytes"); + break; + } + case MCFragment::FT_Data: ++stats::EmittedDataFragments; OS << cast<MCDataFragment>(F).getContents(); @@ -1052,43 +1133,6 @@ bool MCAssembler::relaxLEB(MCAsmLayout &Layout, MCLEBFragment &LF) { return OldSize != LF.getContents().size(); } -/// Check if the branch crosses the boundary. -/// -/// \param StartAddr start address of the fused/unfused branch. -/// \param Size size of the fused/unfused branch. -/// \param BoundaryAlignment alignment requirement of the branch. -/// \returns true if the branch cross the boundary. -static bool mayCrossBoundary(uint64_t StartAddr, uint64_t Size, - Align BoundaryAlignment) { - uint64_t EndAddr = StartAddr + Size; - return (StartAddr >> Log2(BoundaryAlignment)) != - ((EndAddr - 1) >> Log2(BoundaryAlignment)); -} - -/// Check if the branch is against the boundary. -/// -/// \param StartAddr start address of the fused/unfused branch. -/// \param Size size of the fused/unfused branch. -/// \param BoundaryAlignment alignment requirement of the branch. -/// \returns true if the branch is against the boundary. -static bool isAgainstBoundary(uint64_t StartAddr, uint64_t Size, - Align BoundaryAlignment) { - uint64_t EndAddr = StartAddr + Size; - return (EndAddr & (BoundaryAlignment.value() - 1)) == 0; -} - -/// Check if the branch needs padding. -/// -/// \param StartAddr start address of the fused/unfused branch. -/// \param Size size of the fused/unfused branch. -/// \param BoundaryAlignment alignment requirement of the branch. -/// \returns true if the branch needs padding. -static bool needPadding(uint64_t StartAddr, uint64_t Size, - Align BoundaryAlignment) { - return mayCrossBoundary(StartAddr, Size, BoundaryAlignment) || - isAgainstBoundary(StartAddr, Size, BoundaryAlignment); -} - bool MCAssembler::relaxBoundaryAlign(MCAsmLayout &Layout, MCBoundaryAlignFragment &BF) { // BoundaryAlignFragment that doesn't need to align any fragment should not be diff --git a/llvm/lib/MC/MCFragment.cpp b/llvm/lib/MC/MCFragment.cpp index 7d0826802d0af..6e09caaab0957 100644 --- a/llvm/lib/MC/MCFragment.cpp +++ b/llvm/lib/MC/MCFragment.cpp @@ -274,6 +274,9 @@ void MCFragment::destroy() { case FT_Align: delete cast<MCAlignFragment>(this); return; + case FT_NeverAlign: + delete cast<MCNeverAlignFragment>(this); + return; case FT_Data: delete cast<MCDataFragment>(this); return; @@ -342,6 +345,9 @@ LLVM_DUMP_METHOD void MCFragment::dump() const { OS << "<"; switch (getKind()) { case MCFragment::FT_Align: OS << "MCAlignFragment"; break; + case MCFragment::FT_NeverAlign: + OS << "MCNeverAlignFragment"; + break; case MCFragment::FT_Data: OS << "MCDataFragment"; break; case MCFragment::FT_CompactEncodedInst: OS << "MCCompactEncodedInstFragment"; break; @@ -381,6 +387,12 @@ LLVM_DUMP_METHOD void MCFragment::dump() const { << " MaxBytesToEmit:" << AF->getMaxBytesToEmit() << ">"; break; } + case MCFragment::FT_NeverAlign: { + const MCNeverAlignFragment *NAF = cast<MCNeverAlignFragment>(this); + OS << "\n "; + OS << " Alignment:" << NAF->getAlignment() << ">"; + break; + } case MCFragment::FT_Data: { const auto *DF = cast<MCDataFragment>(this); OS << "\n "; diff --git a/llvm/lib/MC/MCObjectStreamer.cpp b/llvm/lib/MC/MCObjectStreamer.cpp index 0ccade91677a4..117475b7dd90b 100644 --- a/llvm/lib/MC/MCObjectStreamer.cpp +++ b/llvm/lib/MC/MCObjectStreamer.cpp @@ -658,6 +658,11 @@ void MCObjectStreamer::emitCodeAlignment(Align Alignment, cast<MCAlignFragment>(getCurrentFragment())->setEmitNops(true, STI); } +void MCObjectStreamer::emitNeverAlignCodeAtEnd(unsigned ByteAlignment, + const MCSubtargetInfo &STI) { + insert(new MCNeverAlignFragment(ByteAlignment, STI)); +} + void MCObjectStreamer::emitValueToOffset(const MCExpr *Offset, unsigned char Value, SMLoc Loc) { diff --git a/llvm/lib/MC/MCStreamer.cpp b/llvm/lib/MC/MCStreamer.cpp index 199d865ea3496..a97cba6c89972 100644 --- a/llvm/lib/MC/MCStreamer.cpp +++ b/llvm/lib/MC/MCStreamer.cpp @@ -1235,6 +1235,8 @@ void MCStreamer::emitValueToAlignment(Align Alignment, int64_t Value, unsigned MaxBytesToEmit) {} void MCStreamer::emitCodeAlignment(Align Alignment, const MCSubtargetInfo *STI, unsigned MaxBytesToEmit) {} +void MCStreamer::emitNeverAlignCodeAtEnd(unsigned ByteAlignment, + const MCSubtargetInfo &STI) {} void MCStreamer::emitValueToOffset(const MCExpr *Offset, unsigned char Value, SMLoc Loc) {} void MCStreamer::emitBundleAlignMode(Align Alignment) {} diff --git a/llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp b/llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp index 6623106109316..6c6bd2cf31e86 100644 --- a/llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp +++ b/llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp @@ -1153,6 +1153,7 @@ class X86AsmParser : public MCTargetAsmParser { bool parseDirectiveArch(); bool parseDirectiveNops(SMLoc L); bool parseDirectiveEven(SMLoc L); + bool parseDirectiveAvoidEndAlign(SMLoc L); bool ParseDirectiveCode(StringRef IDVal, SMLoc L); /// CodeView FPO data directives. @@ -4601,6 +4602,8 @@ bool X86AsmParser::ParseDirective(AsmToken DirectiveID) { return false; } else if (IDVal == ".nops") return parseDirectiveNops(DirectiveID.getLoc()); + else if (IDVal == ".avoid_end_align") + return parseDirectiveAvoidEndAlign(DirectiveID.getLoc()); else if (IDVal == ".even") return parseDirectiveEven(DirectiveID.getLoc()); else if (IDVal == ".cv_fpo_proc") @@ -4695,6 +4698,27 @@ bool X86AsmParser::parseDirectiveEven(SMLoc L) { return false; } +/// Directive for NeverAlign fragment testing, not for general usage! +/// parseDirectiveAvoidEndAlign +/// ::= .avoid_end_align alignment +bool X86AsmParser::parseDirectiveAvoidEndAlign(SMLoc L) { + int64_t Alignment = 0; + SMLoc AlignmentLoc; + AlignmentLoc = getTok().getLoc(); + if (getParser().checkForValidSection() || + getParser().parseAbsoluteExpression(Alignment)) + return true; + + if (getParser().parseEOL("unexpected token in directive")) + return true; + + if (Alignment <= 0) + return Error(AlignmentLoc, "expected a positive alignment"); + + getParser().getStreamer().emitNeverAlignCodeAtEnd(Alignment, getSTI()); + return false; +} + /// ParseDirectiveCode /// ::= .code16 | .code32 | .code64 bool X86AsmParser::ParseDirectiveCode(StringRef IDVal, SMLoc L) { diff --git a/llvm/test/MC/X86/directive-avoid_end_align.s b/llvm/test/MC/X86/directive-avoid_end_align.s new file mode 100644 index 0000000000000..1d748401edc12 --- /dev/null +++ b/llvm/test/MC/X86/directive-avoid_end_align.s @@ -0,0 +1,208 @@ +# RUN: llvm-mc -triple=x86_64 -filetype=obj %s | llvm-objdump --no-show-raw-insn -d - | FileCheck %s +# RUN: not llvm-mc -triple=x86_64 --defsym ERR=1 %s -o /dev/null 2>&1 | FileCheck %s --check-prefix=ERR + +# avoid_end_align has no effect since test doesn't end at alignment boundary: +.avoid_end_align 64 +# CHECK-NOT: nop + testl %eax, %eax +# CHECK: testl %eax, %eax + je .LBB0 + +.fill 58, 1, 0x00 +# NeverAlign followed by MCDataFragment: +# avoid_end_align inserts nop because `test` would end at alignment boundary: +.avoid_end_align 64 +# CHECK: 3e: nop + testl %eax, %eax +# CHECK-NEXT: 3f: testl %eax, %eax + je .LBB0 +# CHECK-NEXT: 41: je +.LBB0: + retq + +.p2align 6 +.L0: +.nops 57 + int3 +# NeverAlign followed by RelaxableFragment: +.avoid_end_align 64 +# CHECK: ba: nop + cmpl $(.L1-.L0), %eax +# CHECK-NEXT: bb: cmpl + je .L0 +# CHECK-NEXT: c1: je +.nops 65 +.L1: + +############################################################################### +# Experiment A: +# Check that NeverAlign doesn't introduce infinite loops in layout. +# Control: +# 1. NeverAlign fragment is not added, +# 2. Short formats of cmp and jcc are used (3 and 2 bytes respectively), +# 3. cmp and jcc are placed such that to be split by 64B alignment boundary. +# 4. jcc would be relaxed to a longer format if at least one byte is added +# between .L10 and je itself, e.g. by adding a NeverAlign padding byte, +# or relaxing cmp instruction. +# 5. cmp would be relaxed to a longer format if at least one byte is added +# between .L11 and .L12, e.g. due to relaxing jcc instruction. +.p2align 6 +# CHECK: 140: int3 +.fill 2, 1, 0xcc +.L10: +.nops 122 + int3 +# CHECK: 1bc: int3 +# no avoid_end_align here +# CHECK-NOT: nop + cmp $(.L12-.L11), %eax +# CHECK: 1bd: cmpl +.L11: + je .L10 +# CHECK-NEXT: 1c0: je +.nops 125 +.L12: + +# Experiment: +# Same setup as control, except NeverAlign fragment is added before cmp. +# Expected effect: +# 1. NeverAlign pads cmp+jcc by one byte since cmp and jcc are split by a 64B +# alignment boundary, +# 2. This extra byte forces jcc relaxation to a longer format (Control rule #4), +# 3. This results in an cmp relaxation (Control rule #5), +# 4. Which in turn makes NeverAlign fragment unnecessary as cmp and jcc +# are no longer split by an alignment boundary (cmp crosses the boundary). +# 5. NeverAlign padding is removed. +# 6. cmp and jcc instruction remain in relaxed form. +# 7. Relaxation converges, layout succeeds. +.p2align 6 +# CHECK: 240: int3 +.fill 2, 1, 0xcc +.L20: +.nops 122 + int3 +# CHECK: 2bc: int3 +.avoid_end_align 64 +# CHECK-NOT: nop + cmp $(.L22-.L21), %eax +# CHECK-NEXT: 2bd: cmpl +.L21: + je .L20 +# CHECK-NEXT: 2c3: je +.nops 125 +.L22: + +############################################################################### +# Experiment B: similar to exp A, but we check that once NeverAlign padding is +# removed from the layout (exp A, experiment step 5), the increased distance +# between the symbols L33 and L34 triggers the relaxation of instruction at +# label L32. +# +# Control 1: using a one-byte instruction at L33 (site of NeverAlign) leads to +# steps 2-3 of exp A, experiment: +# 2. This extra byte forces jcc relaxation to a longer format (Control rule #4), +# 3. This results in an cmp relaxation (Control rule #5), +# => short cmp under L32 +.p2align 6 +# CHECK: 380: int3 +.fill 2, 1, 0xcc +.L30: +.nops 122 + int3 +# CHECK: 3fc: int3 + hlt +#.avoid_end_align 64 +.L33: + cmp $(.L32-.L31), %eax +# CHECK: 3fe: cmpl +.L31: + je .L30 +# CHECK-NEXT: 404: je +.nops 114 +.p2align 1 + int3 + int3 +# CHECK: 47c: int3 +.L34: +.nops 9 +.L32: + cmp $(.L33-.L34), %eax +# CHECK: 487: cmp +# note that the size of cmp is 48a-487 == 3 bytes (distance is exactly -128) + int3 +# CHECK-NEXT: 48a: int3 + +# Control 2: leaving out a byte at L43 (site of NeverAlign), plus +# relaxed jcc and cmp leads to a relaxed cmp under L42 (-129 as cmp's immediate) +.p2align 6 +# CHECK: 4c0: int3 +.fill 2, 1, 0xcc +.L40: +.nops 122 + int3 +# CHECK: 53c: int3 +# int3 +#.avoid_end_align 64 +.L43: + cmp $(.L42-.L41+0x100), %eax +# CHECK: 53d: cmpl +.L41: + je .L40+0x100 +# CHECK-NEXT: 543: je +.nops 114 +.p2align 1 + int3 + int3 +# CHECK: 5bc: int3 +.L44: +.nops 9 +.L42: + cmp $(.L43-.L44), %eax +# CHECK: 5c7: cmp +# note that the size of cmp is 5cd-5c7 == 6 bytes (distance is exactly -129) + int3 +# CHECK-NEXT: 5cd: int3 + +# Experiment +# Checking if removing NeverAlign padding at L53 as a result of alignment and +# relaxation of cmp and jcc following it (see exp A), thus reproducing the case +# in Control 2 (getting a relaxed cmp under L52), is handled correctly. +.p2align 6 +# CHECK: 600: int3 +.fill 2, 1, 0xcc +.L50: +.nops 122 + int3 +# CHECK: 67c: int3 +.avoid_end_align 64 +.L53: +# CHECK-NOT: nop + cmp $(.L52-.L51), %eax +# CHECK-NEXT: 67d: cmpl +.L51: + je .L50 +# CHECK-NEXT: 683: je +.nops 114 +.p2align 1 + int3 + int3 +# CHECK: 6fc: int3 +.L54: +.nops 9 +.L52: + cmp $(.L53-.L54), %eax +# CHECK: 707: cmp +# note that the size of cmp is 70d-707 == 6 bytes (distance is exactly -129) + int3 +# CHECK-NEXT: 70d: int3 + +.ifdef ERR +# ERR: {{.*}}.s:[[#@LINE+1]]:17: error: unknown token in expression +.avoid_end_align +# ERR: {{.*}}.s:[[#@LINE+1]]:18: error: expected absolute expression +.avoid_end_align x +# ERR: {{.*}}.s:[[#@LINE+1]]:18: error: expected a positive alignment +.avoid_end_align 0 +# ERR: {{.*}}.s:[[#@LINE+1]]:20: error: unexpected token in directive +.avoid_end_align 64, 0 +.endif >From d8825073f6243f44e832019c3bd241a1376f4af9 Mon Sep 17 00:00:00 2001 From: Amir Ayupov <aau...@meta.com> Date: Sun, 2 Jun 2024 11:29:35 -0700 Subject: [PATCH 13/15] Revert "[MC] Speed up AttemptToFoldSymbolOffsetDifference in the absence of MCAsmLayout" Summary: This reverts commit 92d2c1b67835248d5d7371fa06381f970687c68f. Causes timeouts in BOLT tests Test Plan: sandcastle Reviewers: ayermolo, davidino, #llvm-bolt Reviewed By: davidino Differential Revision: https://phabricator.intern.facebook.com/D58066252 Tasks: T191101004 Tags: accept2ship, publish_when_ready --- llvm/lib/MC/MCExpr.cpp | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/llvm/lib/MC/MCExpr.cpp b/llvm/lib/MC/MCExpr.cpp index b065d03651c45..9add574b0e5b8 100644 --- a/llvm/lib/MC/MCExpr.cpp +++ b/llvm/lib/MC/MCExpr.cpp @@ -675,14 +675,8 @@ static void AttemptToFoldSymbolOffsetDifference( if (FA == FB) { Reverse = SA.getOffset() < SB.getOffset(); } else if (!isa<MCDummyFragment>(FA)) { - // Testing FA < FB is slow. Use setLayoutOrder to speed up computation. - // The formal layout order will be finalized in MCAssembler::layout. - if (FA->getLayoutOrder() == 0 || FB->getLayoutOrder()== 0) { - unsigned LayoutOrder = 0; - for (MCFragment &F : *FA->getParent()) - F.setLayoutOrder(++LayoutOrder); - } - Reverse = FA->getLayoutOrder() < FB->getLayoutOrder(); + Reverse = std::find_if(std::next(FA->getIterator()), SecA.end(), + [&](auto &I) { return &I == FB; }) != SecA.end(); } uint64_t SAOffset = SA.getOffset(), SBOffset = SB.getOffset(); >From 76d43fad14a1d4bdf27b16f0bc37d6fc5b2e1404 Mon Sep 17 00:00:00 2001 From: Sayhaan Siddiqui <sayh...@meta.com> Date: Tue, 4 Jun 2024 13:04:25 -0700 Subject: [PATCH 14/15] Replace usages of GDBIndex functions Summary: Replace old usages of GDB Index functions to use the new class. Test Plan: Run `ninja check llvm-bolt` Reviewers: ayermolo, rafaelauler, aaupov, maks, #llvm-bolt Reviewed By: ayermolo Differential Revision: https://phabricator.intern.facebook.com/D58156978 Tasks: T187529450 --- bolt/include/bolt/Rewrite/DWARFRewriter.h | 4 +- bolt/lib/Rewrite/DWARFRewriter.cpp | 61 +++++++++++++---------- 2 files changed, 37 insertions(+), 28 deletions(-) diff --git a/bolt/include/bolt/Rewrite/DWARFRewriter.h b/bolt/include/bolt/Rewrite/DWARFRewriter.h index f4754b8be8959..09c984b4c5bc9 100644 --- a/bolt/include/bolt/Rewrite/DWARFRewriter.h +++ b/bolt/include/bolt/Rewrite/DWARFRewriter.h @@ -12,6 +12,7 @@ #include "bolt/Core/DIEBuilder.h" #include "bolt/Core/DebugData.h" #include "bolt/Core/DebugNames.h" +#include "bolt/Core/GDBIndex.h" #include "llvm/ADT/StringRef.h" #include "llvm/CodeGen/DIE.h" #include "llvm/DWP/DWP.h" @@ -140,7 +141,8 @@ class DWARFRewriter { makeFinalLocListsSection(DWARFVersion Version); /// Finalize type sections in the main binary. - CUOffsetMap finalizeTypeSections(DIEBuilder &DIEBlder, DIEStreamer &Streamer); + CUOffsetMap finalizeTypeSections(DIEBuilder &DIEBlder, DIEStreamer &Streamer, + GDBIndex &GDBIndexSection); /// Process and write out CUs that are passsed in. void finalizeCompileUnits(DIEBuilder &DIEBlder, DIEStreamer &Streamer, diff --git a/bolt/lib/Rewrite/DWARFRewriter.cpp b/bolt/lib/Rewrite/DWARFRewriter.cpp index 701e6c94ee586..a0a04d4862bf5 100644 --- a/bolt/lib/Rewrite/DWARFRewriter.cpp +++ b/bolt/lib/Rewrite/DWARFRewriter.cpp @@ -185,6 +185,7 @@ namespace bolt { class DIEStreamer : public DwarfStreamer { DIEBuilder *DIEBldr; DWARFRewriter &Rewriter; + GDBIndex &GDBIndexSection; private: /// Emit the compilation unit header for \p Unit in the debug_info @@ -247,7 +248,7 @@ class DIEStreamer : public DwarfStreamer { const uint64_t TypeSignature = cast<DWARFTypeUnit>(Unit).getTypeHash(); DIE *TypeDIE = DIEBldr->getTypeDIE(Unit); const DIEBuilder::DWARFUnitInfo &UI = DIEBldr->getUnitInfoByDwarfUnit(Unit); - Rewriter.addGDBTypeUnitEntry( + GDBIndexSection.addGDBTypeUnitEntry( {UI.UnitOffset, TypeSignature, TypeDIE->getOffset()}); if (Unit.getVersion() < 5) { // Switch the section to .debug_types section. @@ -279,11 +280,12 @@ class DIEStreamer : public DwarfStreamer { public: DIEStreamer(DIEBuilder *DIEBldr, DWARFRewriter &Rewriter, + GDBIndex &GDBIndexSection, DWARFLinkerBase::OutputFileType OutFileType, raw_pwrite_stream &OutFile, DWARFLinkerBase::MessageHandlerTy Warning) : DwarfStreamer(OutFileType, OutFile, Warning), DIEBldr(DIEBldr), - Rewriter(Rewriter){}; + Rewriter(Rewriter), GDBIndexSection(GDBIndexSection) {}; using DwarfStreamer::emitCompileUnitHeader; @@ -326,12 +328,11 @@ static cl::opt<bool> KeepARanges( "keep or generate .debug_aranges section if .gdb_index is written"), cl::Hidden, cl::cat(BoltCategory)); -static cl::opt<bool> -DeterministicDebugInfo("deterministic-debuginfo", - cl::desc("disables parallel execution of tasks that may produce " - "nondeterministic debug info"), - cl::init(true), - cl::cat(BoltCategory)); +static cl::opt<bool> DeterministicDebugInfo( + "deterministic-debuginfo", + cl::desc("disables parallel execution of tasks that may produce " + "nondeterministic debug info"), + cl::init(true), cl::cat(BoltCategory)); static cl::opt<std::string> DwarfOutputPath( "dwarf-output-path", @@ -460,10 +461,11 @@ static std::optional<uint64_t> getAsAddress(const DWARFUnit &DU, static std::unique_ptr<DIEStreamer> createDIEStreamer(const Triple &TheTriple, raw_pwrite_stream &OutFile, StringRef Swift5ReflectionSegmentName, DIEBuilder &DIEBldr, - DWARFRewriter &Rewriter) { + DWARFRewriter &Rewriter, GDBIndex &GDBIndexSection) { std::unique_ptr<DIEStreamer> Streamer = std::make_unique<DIEStreamer>( - &DIEBldr, Rewriter, DWARFLinkerBase::OutputFileType::Object, OutFile, + &DIEBldr, Rewriter, GDBIndexSection, + DWARFLinkerBase::OutputFileType::Object, OutFile, [&](const Twine &Warning, StringRef Context, const DWARFDie *) {}); Error Err = Streamer->init(TheTriple, Swift5ReflectionSegmentName); if (Err) @@ -484,13 +486,12 @@ emitUnit(DIEBuilder &DIEBldr, DIEStreamer &Streamer, DWARFUnit &Unit) { return {U.UnitOffset, U.UnitLength, TypeHash}; } -static void emitDWOBuilder(const std::string &DWOName, - DIEBuilder &DWODIEBuilder, DWARFRewriter &Rewriter, - DWARFUnit &SplitCU, DWARFUnit &CU, - DWARFRewriter::DWPState &State, - DebugLocWriter &LocWriter, - DebugStrOffsetsWriter &StrOffstsWriter, - DebugStrWriter &StrWriter) { +static void +emitDWOBuilder(const std::string &DWOName, DIEBuilder &DWODIEBuilder, + DWARFRewriter &Rewriter, DWARFUnit &SplitCU, DWARFUnit &CU, + DWARFRewriter::DWPState &State, DebugLocWriter &LocWriter, + DebugStrOffsetsWriter &StrOffstsWriter, + DebugStrWriter &StrWriter, GDBIndex &GDBIndexSection) { // Populate debug_info and debug_abbrev for current dwo into StringRef. DWODIEBuilder.generateAbbrevs(); DWODIEBuilder.finish(); @@ -500,8 +501,9 @@ static void emitDWOBuilder(const std::string &DWOName, std::make_shared<raw_svector_ostream>(OutBuffer); const object::ObjectFile *File = SplitCU.getContext().getDWARFObj().getFile(); auto TheTriple = std::make_unique<Triple>(File->makeTriple()); - std::unique_ptr<DIEStreamer> Streamer = createDIEStreamer( - *TheTriple, *ObjOS, "DwoStreamerInitAug2", DWODIEBuilder, Rewriter); + std::unique_ptr<DIEStreamer> Streamer = + createDIEStreamer(*TheTriple, *ObjOS, "DwoStreamerInitAug2", + DWODIEBuilder, Rewriter, GDBIndexSection); DWARFRewriter::UnitMetaVectorType TUMetaVector; DWARFRewriter::UnitMeta CUMI = {0, 0, 0}; if (SplitCU.getContext().getMaxDWOVersion() >= 5) { @@ -661,6 +663,7 @@ void DWARFRewriter::updateDebugInfo() { DWARF5AcceleratorTable DebugNamesTable(opts::CreateDebugNames, BC, *StrWriter); + GDBIndex GDBIndexSection(BC); DWPState State; if (opts::WriteDWP) initDWPState(State); @@ -715,7 +718,8 @@ void DWARFRewriter::updateDebugInfo() { TempRangesSectionWriter->finalizeSection(); emitDWOBuilder(DWOName, DWODIEBuilder, *this, **SplitCU, *Unit, State, - DebugLocDWoWriter, DWOStrOffstsWriter, DWOStrWriter); + DebugLocDWoWriter, DWOStrOffstsWriter, DWOStrWriter, + GDBIndexSection); } if (Unit->getVersion() >= 5) { @@ -740,9 +744,10 @@ void DWARFRewriter::updateDebugInfo() { std::make_unique<raw_svector_ostream>(OutBuffer); const object::ObjectFile *File = BC.DwCtx->getDWARFObj().getFile(); auto TheTriple = std::make_unique<Triple>(File->makeTriple()); - std::unique_ptr<DIEStreamer> Streamer = - createDIEStreamer(*TheTriple, *ObjOS, "TypeStreamer", DIEBlder, *this); - CUOffsetMap OffsetMap = finalizeTypeSections(DIEBlder, *Streamer); + std::unique_ptr<DIEStreamer> Streamer = createDIEStreamer( + *TheTriple, *ObjOS, "TypeStreamer", DIEBlder, *this, GDBIndexSection); + CUOffsetMap OffsetMap = + finalizeTypeSections(DIEBlder, *Streamer, GDBIndexSection); const bool SingleThreadedMode = opts::NoThreads || opts::DeterministicDebugInfo; @@ -772,7 +777,8 @@ void DWARFRewriter::updateDebugInfo() { finalizeDebugSections(DIEBlder, DebugNamesTable, *Streamer, *ObjOS, OffsetMap); - updateGdbIndexSection(OffsetMap, CUIndex); + GDBIndexSection.updateGdbIndexSection(OffsetMap, CUIndex, + *ARangesSectionWriter); } void DWARFRewriter::updateUnitDebugInfo( @@ -1437,7 +1443,8 @@ void DWARFRewriter::updateLineTableOffsets(const MCAsmLayout &Layout) { } CUOffsetMap DWARFRewriter::finalizeTypeSections(DIEBuilder &DIEBlder, - DIEStreamer &Streamer) { + DIEStreamer &Streamer, + GDBIndex &GDBIndexSection) { // update TypeUnit DW_AT_stmt_list with new .debug_line information. auto updateLineTable = [&](const DWARFUnit &Unit) -> void { DIE *UnitDIE = DIEBlder.getUnitDIEbyUnit(Unit); @@ -1457,8 +1464,8 @@ CUOffsetMap DWARFRewriter::finalizeTypeSections(DIEBuilder &DIEBlder, std::make_shared<raw_svector_ostream>(OutBuffer); const object::ObjectFile *File = BC.DwCtx->getDWARFObj().getFile(); auto TheTriple = std::make_unique<Triple>(File->makeTriple()); - std::unique_ptr<DIEStreamer> TypeStreamer = - createDIEStreamer(*TheTriple, *ObjOS, "TypeStreamer", DIEBlder, *this); + std::unique_ptr<DIEStreamer> TypeStreamer = createDIEStreamer( + *TheTriple, *ObjOS, "TypeStreamer", DIEBlder, *this, GDBIndexSection); // generate debug_info and CUMap CUOffsetMap CUMap; >From dc89e76b5c14374e42f344d7eb3a3eb0ad2fe537 Mon Sep 17 00:00:00 2001 From: Sayhaan Siddiqui <sayh...@meta.com> Date: Fri, 21 Jun 2024 12:38:20 -0700 Subject: [PATCH 15/15] Formatting changes --- bolt/lib/Rewrite/DWARFRewriter.cpp | 2 -- 1 file changed, 2 deletions(-) diff --git a/bolt/lib/Rewrite/DWARFRewriter.cpp b/bolt/lib/Rewrite/DWARFRewriter.cpp index a0a04d4862bf5..d2d6808ef3946 100644 --- a/bolt/lib/Rewrite/DWARFRewriter.cpp +++ b/bolt/lib/Rewrite/DWARFRewriter.cpp @@ -2344,10 +2344,8 @@ void DWARFRewriter::convertToRangesPatchDebugInfo( LegacyRangesWritersAndDIEsByCU[*Unit.getDWOId()].Die = &Die; } } - // HighPC was conveted into DW_AT_ranges. // For DWARF5 we only access ranges through index. - DIEBldr.replaceValue(&Die, HighPCAttrInfo.getAttribute(), dwarf::DW_AT_ranges, RangesForm, DIEInteger(RangesSectionOffset)); } _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
